WebGL / Filter geometries before processing them for rendering #15416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
filter()
method on theMixedGeometryBatch
class. Before generating WebGL buffers from a geometry batch, theVectorStyleRenderer
will apply the style filter and exclude from the batch any geometry that does not match this filter. The style filter expression is evaluated on the CPU.Some filters might not be evaluated at buffer generation time (e.g. a filter depending on
time
orresolution
which are dynamic parameters). This entails that the filter is also still applied on the GPU (fragment shader) to make sure that we filter our all relevant features at any given frame.This change typically makes vector tiles processing a little bit longer, but is essential when rendering styles composed of dozens of different rules where it provides a huge performance boost.
Rebased on #15415
Part of #15413