Adjust canvas getData() offsets and rendered gutter for served image size #13609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the examples and docs from this branch here: https://deploy-preview-13609--ol-site.netlify.app/. |
fb52217
to
1e38f13
Compare
|
Wouldn't it simplify things in a lot of places if we handled the corner case of a |
|
No, gutter is now also available for XYZ (currently we have no examples). When rendering with WebGL without a gutter there are always tile edge effects when interpolating, sometimes quite obvious as below. Mapbox and Nextzen have guttered tiles which avoid that, but to work the gutter must be clipped during rendering
|
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13605 for canvas rendering
Calculate
layer.getData()offsets based on the actual image size in case image is scaled to fit specified tile size.Also fix the rendering so gutter is adjusted for image size. Previously canvas rendering only handled gutter for TileWMS where the image was requested to fit the tile grid. Canvas rendering is now consistent with WebGL rendering applying gutter to scaled textures.
To avoid conflicts a separate commit in #13575 applies the change to WebGL. For WebGL renderer this was fixed by #13648