Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337265: [Graal] Add basic libgraal GitHub Actions job #20347

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Jul 26, 2024

Since libgraal is built with SVM and SVM is closely tied to OpenJDK internals, it's easy enough for an OpenJDK change to break building libgraal.
This PR adds a GitHub Actions job that does a basic build and test of libgraal by pulling sources from the graal repo.
The job always exits with success but if libgraal building or testing fails, a comment is added to head commit of the PR that triggers a notification to be sent to the Graal compiler team.
The comment makes it clear that no further action is needed by the PR author.

Example comment: dougxc@b567ab9#commitcomment-144869332


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8337265

Issue

  • JDK-8337265: Test static-libs build in GitHub Actions (Enhancement - P4) ⚠️ Title mismatch between PR and JBS. ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20347/head:pull/20347
$ git checkout pull/20347

Update a local copy of the PR:
$ git checkout pull/20347
$ git pull https://git.openjdk.org/jdk.git pull/20347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20347

View PR using the GUI difftool:
$ git pr show -t 20347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20347.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2024

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

@dougxc The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@dougxc dougxc force-pushed the JDK-8337265 branch 9 times, most recently from db594e6 to 8e4fff0 Compare July 30, 2024 20:57
github-actions bot referenced this pull request in dougxc/jdk Jul 30, 2024
github-actions bot referenced this pull request in dougxc/jdk Jul 30, 2024
github-actions bot referenced this pull request in dougxc/jdk Jul 30, 2024
github-actions bot referenced this pull request in dougxc/jdk Jul 30, 2024
github-actions bot referenced this pull request in dougxc/jdk Jul 30, 2024
@dougxc dougxc force-pushed the JDK-8337265 branch 3 times, most recently from e0b1c66 to 4aa636e Compare July 31, 2024 07:38
github-actions bot referenced this pull request in dougxc/jdk Jul 31, 2024
@dougxc dougxc force-pushed the JDK-8337265 branch 3 times, most recently from f48c77c to bf974d2 Compare July 31, 2024 11:30
github-actions bot referenced this pull request in dougxc/jdk Jul 31, 2024
github-actions bot referenced this pull request in dougxc/jdk Jul 31, 2024
github-actions bot referenced this pull request in dougxc/jdk Jul 31, 2024
This reverts commit 1d7573c.
github-actions bot referenced this pull request in dougxc/jdk Jul 31, 2024
github-actions bot referenced this pull request in dougxc/jdk Jul 31, 2024
github-actions bot referenced this pull request in dougxc/jdk Jul 31, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2024

@dougxc This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant