-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337265: [Graal] Add basic libgraal GitHub Actions job #20347
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
db594e6
to
8e4fff0
Compare
e0b1c66
to
4aa636e
Compare
f48c77c
to
bf974d2
Compare
This reverts commit 1d7573c.
@dougxc This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Since libgraal is built with SVM and SVM is closely tied to OpenJDK internals, it's easy enough for an OpenJDK change to break building libgraal.
This PR adds a GitHub Actions job that does a basic build and test of libgraal by pulling sources from the graal repo.
The job always exits with success but if libgraal building or testing fails, a comment is added to head commit of the PR that triggers a notification to be sent to the Graal compiler team.
The comment makes it clear that no further action is needed by the PR author.
Example comment: dougxc@b567ab9#commitcomment-144869332
Progress
Integration blocker
Issue
Backport <hash>
with the hash of the original commit. See Backports.Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20347/head:pull/20347
$ git checkout pull/20347
Update a local copy of the PR:
$ git checkout pull/20347
$ git pull https://git.openjdk.org/jdk.git pull/20347/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20347
View PR using the GUI difftool:
$ git pr show -t 20347
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20347.diff