8337213: Shenandoah: Add verification for class mirrors

[shipilev]

When working in Leyden, I noticed some oddities when loading Class mirrors from the CDS archive. These are not caught by Shenandoah asserts or verifier, since the problem is due to wrong metadata. We can amend verification to test these.

Additional testing:

• Linux x86_64 server fastdebug, all with -XX:+UseShenandoahGC
• Linux x86_64 server fastdebug, all with -XX:+UseShenandoahGC -XX:+ShenandoahVerify

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8337213: Shenandoah: Add verification for class mirrors (Enhancement - P4)

Reviewers

• Roman Kennke (@rkennke - Reviewer)
• William Kemper (@earthling-amzn - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20332/head:pull/20332
$ git checkout pull/20332

Update a local copy of the PR:
$ git checkout pull/20332
$ git pull https://git.openjdk.org/jdk.git pull/20332/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20332

View PR using the GUI difftool:
$ git pr show -t 20332

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20332.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337213: Shenandoah: Add verification for class mirrors

Reviewed-by: rkennke, wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

• ab27090: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute
• bd36b6a: 8337285: Examine java.text.DecimalFormat API for api/implXxx tag usage
• a86244f: 6381729: Javadoc for generic constructor doesn't document type parameter
• c4e6255: 8332738: Debug agent can deadlock on callbackLock when using StackFrame.PopFrames
• c23d37e: 8337300: java/lang/Process/WaitForDuration.java leaves child process behind
• ee365d7: 8336342: Fix known X11 library locations in sysroot
• cd52ad8: 8337267: [REDO] G1: Refactor G1RebuildRSAndScrubTask
• 9124a94: 8337165: Test jdk/jfr/event/gc/stacktrace/TestG1YoungAllocationPendingStackTrace.java failed: IndexOutOfBoundsException: Index 64 out of bounds for length 64
• db168d9: 8336966: Alpine Linux x86_64 compilation error: sendfile64
• dab2a0b: 8337222: gc/TestDisableExplicitGC.java fails due to unexpected CodeCache GC
• ... and 75 more: https://git.openjdk.org/jdk/compare/0db6c15efe255bd313fb2b827d2ee05171e62ae9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (45e2e630)

[rkennke]

Looks reasonable. Thanks!

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit 156f0b4.
Since your change was applied there have been 88 commits pushed to the master branch:

• 9e6e0a8: 8336343: Add more known sysroot library locations for ALSA
• bc7c255: 8337416: Fix -Wzero-as-null-pointer-constant warnings in misc. runtime code
• 7e21d4c: 8337268: Redundant Math.ceil in StyleSheet.ListPainter#drawShape
• ab27090: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute
• bd36b6a: 8337285: Examine java.text.DecimalFormat API for api/implXxx tag usage
• a86244f: 6381729: Javadoc for generic constructor doesn't document type parameter
• c4e6255: 8332738: Debug agent can deadlock on callbackLock when using StackFrame.PopFrames
• c23d37e: 8337300: java/lang/Process/WaitForDuration.java leaves child process behind
• ee365d7: 8336342: Fix known X11 library locations in sysroot
• cd52ad8: 8337267: [REDO] G1: Refactor G1RebuildRSAndScrubTask
• ... and 78 more: https://git.openjdk.org/jdk/compare/0db6c15efe255bd313fb2b827d2ee05171e62ae9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 156f0b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.