-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337213: Shenandoah: Add verification for class mirrors #20332
8337213: Shenandoah: Add verification for class mirrors #20332
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 85 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. Thanks!
Thanks! /integrate |
Going to push as commit 156f0b4.
Your commit was automatically rebased without conflicts. |
When working in Leyden, I noticed some oddities when loading Class mirrors from the CDS archive. These are not caught by Shenandoah asserts or verifier, since the problem is due to wrong metadata. We can amend verification to test these.
Additional testing:
all
with-XX:+UseShenandoahGC
all
with-XX:+UseShenandoahGC -XX:+ShenandoahVerify
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20332/head:pull/20332
$ git checkout pull/20332
Update a local copy of the PR:
$ git checkout pull/20332
$ git pull https://git.openjdk.org/jdk.git pull/20332/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20332
View PR using the GUI difftool:
$ git pr show -t 20332
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20332.diff
Webrev
Link to Webrev Comment