Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331341: secondary_super_cache does not scale well: C1 and interpreter #19989

Open
wants to merge 60 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
b814460
Stage
Jun 4, 2024
97dec4c
Temp
Jun 4, 2024
491177c
Super
Jun 12, 2024
3db4a14
Merge branch 'clean' into JDK-8331658-work
Jun 12, 2024
4b3aae9
Inter
Jun 13, 2024
9232639
Inter
Jun 14, 2024
02a4e3c
Temp
Jun 19, 2024
db07cbd
Ready for x86
Jun 20, 2024
3288967
Ready for x86
Jun 20, 2024
4fd1215
First stab at x86
Jun 21, 2024
345f22a
Converging
Jun 24, 2024
6b286a3
UseSecondarySupersTable on by default (temp)
Jun 25, 2024
a027a57
Temp
Jun 26, 2024
f095fee
Cleanup
Jun 26, 2024
de17b44
Cleanup
Jun 26, 2024
84a978c
Merge branch 'clean' into JDK-8331658-work
Jul 2, 2024
73ff8fb
Temp
Jul 2, 2024
80d33b9
Temp
Jul 2, 2024
e38e086
Temp
Jul 2, 2024
16f60f9
Fix x86
Jul 2, 2024
d2771bc
Fix x86-32
Jul 4, 2024
bc5afd0
Merge remote-tracking branch 'refs/remotes/origin/JDK-8331658-work' i…
Jul 4, 2024
cec26c7
Temp
Jul 4, 2024
876987e
Small
Jul 4, 2024
b75d993
small
Jul 4, 2024
7d7694c
Cleanup tests
Jul 4, 2024
bfe9cee
Negated tests
Jul 18, 2024
129987f
Cleanup check_klass_subtype_fast_path for AArch64, deleting dead code
Jul 19, 2024
0421b92
Review feedback
Jul 19, 2024
2b002e4
Review feedback
Jul 19, 2024
98f6b2b
Review feedback
Jul 19, 2024
69d1d8d
Review comments
Jul 22, 2024
c252efc
Review comments
Jul 22, 2024
02cfd13
Review comments
Jul 22, 2024
48e80a1
Review comments
Jul 24, 2024
54050a5
Minor cleanup
Jul 24, 2024
1242584
Merge branch 'JDK-8331658-work' of https://github.com/theRealAph/jdk …
Jul 24, 2024
7858fef
temp
Jul 25, 2024
011a388
Cleanup
Jul 25, 2024
248f44d
Merge branch 'clean' into JDK-8331658-work
Jul 25, 2024
e958101
Fix test failure
Jul 26, 2024
329f487
Minor
Jul 29, 2024
193478d
Experiment: test bitmap upfront.
Jul 29, 2024
0571877
Experiment: test bitmap upfront.
Jul 29, 2024
5cca1cc
Review comments
Jul 31, 2024
c33e1bd
Fix AArch64
Jul 31, 2024
4c9a081
Review comments
Jul 31, 2024
2769d9e
Merge branch 'JDK-8331658-work' of https://github.com/theRealAph/jdk …
Jul 31, 2024
24aca9a
Reorganize x86
Aug 1, 2024
e41f15a
Untabify
Aug 1, 2024
4c7fad7
use assert rather than guarantee
Aug 1, 2024
7792ca8
Fix shared code
Aug 1, 2024
eb73993
Fix shared code
Aug 1, 2024
51c68a0
Cleanup
Aug 6, 2024
5b46b38
Merge from JDK head.
Aug 12, 2024
790939c
Merge branch 'clean' into JDK-8331658-work
Aug 12, 2024
77de087
Fix merge
Aug 12, 2024
dd42fe9
Merge branch 'clean' into JDK-8331658-work
Aug 16, 2024
fe754fb
Use post-incrememnt RegSet operator.
Aug 30, 2024
a726b62
Fix s390
Aug 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix shared code
  • Loading branch information
Andrew Haley committed Aug 1, 2024
commit 7792ca8ab7529c8024568a20ddc831288c14983d
2 changes: 1 addition & 1 deletion src/hotspot/share/oops/klass.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ bool Klass::linear_search_secondary_supers(const Klass* k) const {
// occupancy bitmap rotated such that Bit 1 is the next bit to test,
// search for k.
bool Klass::fallback_search_secondary_supers(const Klass* k, int index, uintx rotated_bitmap) const {
if (rotated_bitmap == SECONDARY_SUPERS_BITMAP_FULL) {
if (secondary_supers()->length() > SECONDARY_SUPERS_TABLE_SIZE - 2) {
return linear_search_secondary_supers(k);
}

Expand Down