8145948: C2: Initializing volatile fields to default values should be optimized #19721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
New benchmark shows expected improvements. Actually, I suppose we can eliminate the barriers for all volatile writes in initializers, and instead rely on final-field-like semantics, but that requires a more comprehensive arguments, so I'll leave that for future work.
Additional testing:
all
all
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19721/head:pull/19721
$ git checkout pull/19721
Update a local copy of the PR:
$ git checkout pull/19721
$ git pull https://git.openjdk.org/jdk.git pull/19721/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19721
View PR using the GUI difftool:
$ git pr show -t 19721
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19721.diff