Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes item value hidden for equipment accordion button #1396

Merged
merged 1 commit into from
May 20, 2022

Conversation

tarag
Copy link
Contributor

@tarag tarag commented May 20, 2022

Value was hard coded to avoid the infamous NULL on groups (PR #1285) without having to configure items, but this causes issues for legitimate uses where you'd want to see the value displayed.

@tarag tarag requested a review from a team as a code owner May 20, 2022 17:21
@relativeci
Copy link

relativeci bot commented May 20, 2022

Job #403: Bundle Size — 10.71MB (-0.04%).

59a1a23 vs 1fd5582

Changed metrics (3/10)
Metric Current Baseline
Initial JS 1.67MB(-0.11%) 1.67MB
Cache Invalidation 23.67% 23.64%
Duplicate Code 1.98%(-0.5%) 1.99%
Changed assets by type (1/7)
            Current     Baseline
JS 8.65MB (-0.05%) 8.65MB

View Job #403 report on app.relative-ci.com

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@ghys ghys merged commit 49c2a9a into openhab:main May 20, 2022
@ghys ghys added enhancement New feature or request main ui Main UI labels May 29, 2022
@ghys ghys added this to the 3.3 milestone May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants