Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Average, accumulation compute not hourly period of time #266

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Average, accumulation compute not hourly period of time #266

merged 1 commit into from
Dec 23, 2020

Conversation

did-g
Copy link
Contributor

@did-g did-g commented Dec 22, 2020

Hi,
should help with

#262

@norulz norulz merged commit e8c291d into opengribs:master Dec 23, 2020
@norulz
Copy link
Collaborator

norulz commented Dec 23, 2020

I tried the fix and it appear to be OK.
I only tried it with the particular grib where I noticed the issue.

@norulz
Copy link
Collaborator

norulz commented Dec 23, 2020

Hi @did-g

It works for grib2 but not for grib1.
I've attached a grib1 fileb
apcp_ver1.zip

@norulz
Copy link
Collaborator

norulz commented Dec 24, 2020

Hi @did-g

It works for grib2 but not for grib1.
apcp_ver1.zip

I've attached a grib1 fileb

@did-g
Copy link
Contributor Author

did-g commented Dec 24, 2020

Thanks, I'll fix it.

@did-g did-g deleted the time_range branch December 26, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@did-g @norulz