fix: mock statsD client during dev/test env #7550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenLSM
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes FRM-1800
When running tests locally (esp during verbose mode), the jest logs are often spammed with error messages due to the above. Adding to the noise and making it hard to debug test cases.
This is a acknowledged issue and occurs all the time when backend unit tests are run.
See example of noise added to test debug logs:
Solution
The hotshot client should be run as a mock during dev/test mode as logging to DD is not desired during test/dev.
( see hot-shot mock: https://github.com/brightcove/hot-shots )
Doing so removes the error messages above