Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: adding more german translations #8920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FemmeNoire
Copy link
Contributor

added some more german translations for additives, ingredients, minerals and vitamins

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients 🧪 additives labels Aug 28, 2023
@FemmeNoire FemmeNoire changed the title adding more german translations taxonomy: adding more german translations Aug 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Aug 28, 2023
@@ -28019,6 +28021,10 @@ hu:főtt fehér rizs
nl:gekookte witte rijst
# ingredient/cooked-white-rice has 75 products in 2 languages @2018-12-19

<en:cooked and seasoned rice
en:cooked and seasoned rice
de:gekochter gewürzter Reis, gekochter gewuerzter Reis, gekochter und gewürzter Reis, gekochter und gewuerzter Reis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one, it's better to add a new en:seasoned entry in ingredients_processing.txt (and its German translation) so that we can match things like cooked and seasoned anything, like "seasoned vegetables", without having to add all combinations as individual entries in ingredients.txt


<en:chicken meat
en:cooked chicken meat with liquid seasoning
de:gegartes Hühnerfleisch flüssig gewürzt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, instead of adding those 2 entries, we could just have a "with liquid seasoning" processing, (or simpler, we just make it a synonym of the en:seasoned processing:

in ingredients_processing.txt:

en:seasoned, with seasoning, with liquid seasoning

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the new translations and synonyms!

I added some comments for new entries that could be covered better by adding an en:seasoned processing, similar to the en:flavoured processing we already have.

@teolemon teolemon added the German https://wiki.openfoodfacts.org/Local_Communities/GermanTeam label Sep 3, 2023
@@ -14219,7 +14221,7 @@ bg:растително масло и мазнина, растителни ма
ca:Oli i greix vegetal
cs:Rostlinný olej a tuk
da:Vegetabilsk olie og fedt
de:pflanzliche Öle und Fette
de:pflanzliche Öle und Fette, Pflanzliche Öle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
de:pflanzliche Öle und Fette, Pflanzliche Öle
de:pflanzliche Öle und Fette

There is another entry for vegetal oil alone

@@ -24308,7 +24310,7 @@ sv:fullkornshavre

<en:oat
en:gluten free oats
de:glutenfreier Hafer
de:glutenfreier Hafer,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
de:glutenfreier Hafer,
de:glutenfreier Hafer

Typo

@@ -30802,7 +30808,7 @@ pl:teksturowane białko sojowe, teksturat białka sojowego
<en:dehydrated soy protein
en:rehydrated soy protein
bg:рехидратиран соев протеин
de:Rehydriertes Sojaprotein, rehydriertes Sojaproteinisolat, angerührtes Sojaproteinisolat
de:Rehydriertes Sojaprotein, rehydriertes Sojaproteinisolat, angerührtes Sojaproteinisolat, Sojaeiweiß-Isolat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
de:Rehydriertes Sojaprotein, rehydriertes Sojaproteinisolat, angerührtes Sojaproteinisolat, Sojaeiweiß-Isolat
de:Rehydriertes Sojaprotein, rehydriertes Sojaproteinisolat, angerührtes Sojaproteinisolat

There is another entry of soy protein isolate

@@ -81933,7 +81953,7 @@ bg:Инулин
bs:Inulin
ca:Inulina
cs:Inulin
da:Inulin
da:Inulin, Nutriose, Ballaststoff Nutriose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
da:Inulin, Nutriose, Ballaststoff Nutriose
da:Inulin

Nutriose is a trademark, it is not equivalent to inulin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives German https://wiki.openfoodfacts.org/Local_Communities/GermanTeam 🥗 Ingredients 💥 Merge Conflicts 💥 Merge Conflicts 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
Development

Successfully merging this pull request may close these issues.

4 participants