Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OxF asset links for the legacy mobile apps #8379

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Apr 29, 2023

What

  • The Android legacy versions for Open Beauty Facts, Open Pet Food Facts, Open Products Facts already support deep links in their production releases
    We have never uploaded Digital Asset JSONs to secondary projects
    We get errors as a result

To-Do

  • Add iOS mobile assets files as well, for OFF and OxF

Fixes

@teolemon teolemon linked an issue Apr 29, 2023 that may be closed by this pull request
@teolemon
Copy link
Member Author

FYI @VaiTon @g123k

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2023

Codecov Report

Merging #8379 (870d471) into main (bf5e755) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8379   +/-   ##
=======================================
  Coverage   48.23%   48.23%           
=======================================
  Files         109      109           
  Lines       21058    21058           
  Branches     4741     4741           
=======================================
  Hits        10157    10157           
  Misses       9626     9626           
  Partials     1275     1275           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon added 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps labels Apr 29, 2023
@g123k
Copy link
Collaborator

g123k commented Apr 29, 2023

You don't have to create multiple files. Just one is enough

@teolemon teolemon changed the title feat: oxf asset links feat: OxF asset links for the legacy mobile apps May 2, 2023
@github-actions github-actions bot removed 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org labels May 2, 2023
@teolemon
Copy link
Member Author

teolemon commented May 2, 2023

  • @g123k I added the file for the Apple App as well (which has potentially good side effect on credential sharing between Safari and the native app)
  • For the other app, concatenating everything within one file would create clashes, unless we tweak the handled URLs somehow ?

@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel
Copy link
Member

@teolemon is this a draft or no more ?

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. Stale
Projects
Development

Successfully merging this pull request may close these issues.

Upload Digital Asset JSONs to secondary projects
5 participants