Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added the statiegeldblik entry in recyling and logo #8337

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

aleene
Copy link
Contributor

@aleene aleene commented Apr 20, 2023

What

Added the statiegeldblik entry in recyling and logo

Part of

@aleene aleene requested a review from a team as a code owner April 20, 2023 07:28
@github-actions github-actions bot added 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Apr 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #8337 (6164a94) into main (0f0a146) will decrease coverage by 4.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8337      +/-   ##
==========================================
- Coverage   47.88%   42.90%   -4.98%     
==========================================
  Files          65       62       -3     
  Lines       20266    19948     -318     
  Branches     4916     4871      -45     
==========================================
- Hits         9704     8559    -1145     
- Misses       9307    10244     +937     
+ Partials     1255     1145     -110     

see 26 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aleene
Copy link
Contributor Author

aleene commented Apr 21, 2023

It fails, but I did not see the cause

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aleene
LGTM, but you have commited a .DS_Store by error I think

@alexgarel
Copy link
Member

@aleene this is the difference I got if I run make test-unit test="packaging.t --update-expected-result":

--- a/tests/unit/expected_test_results/packaging/packaging_text_nl_glazen_pot_met_deksel.json
+++ b/tests/unit/expected_test_results/packaging/packaging_text_nl_glazen_pot_met_deksel.json
@@ -9,7 +9,7 @@
       "en:glass",
       "en:metal"
    ],
-   "packaging_recycling_tags" : [nl:glasbak],
+   "packaging_recycling_tags" : [],
    "packaging_shapes_tags" : [
       "en:jar",
       "en:lid"

Corresponding test:

	# sentence glazen pot + deksel
	[
		'packaging_text_nl_glazen_pot_met_deksel',
		{
			lc => "nl",
			packaging_text => "1 glazen pot, 1 metalen deksel"
		}
	],

Do you think it's normal ?

@aleene
Copy link
Contributor Author

aleene commented May 11, 2023

The test result was ok. A glass pot and metal lid should be put into the glasbak (metal is ok). If the test fails, the procesing does not give the required result.

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon changed the title chore: added statiegeldblik chore: Added the statiegeldblik entry in recyling and logo Nov 9, 2023
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jan 28, 2024
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Mar 26, 2024
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Apr 6, 2024
@teolemon teolemon requested review from stephanegigandet and a team April 30, 2024 14:37
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Apr 30, 2024
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 Merge Conflicts 💥 Merge Conflicts 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

5 participants