-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Added the statiegeldblik entry in recyling and logo #8337
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8337 +/- ##
==========================================
- Coverage 47.88% 42.90% -4.98%
==========================================
Files 65 62 -3
Lines 20266 19948 -318
Branches 4916 4871 -45
==========================================
- Hits 9704 8559 -1145
- Misses 9307 10244 +937
+ Partials 1255 1145 -110 see 26 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
It fails, but I did not see the cause |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aleene
LGTM, but you have commited a .DS_Store by error I think
@aleene this is the difference I got if I run --- a/tests/unit/expected_test_results/packaging/packaging_text_nl_glazen_pot_met_deksel.json
+++ b/tests/unit/expected_test_results/packaging/packaging_text_nl_glazen_pot_met_deksel.json
@@ -9,7 +9,7 @@
"en:glass",
"en:metal"
],
- "packaging_recycling_tags" : [nl:glasbak],
+ "packaging_recycling_tags" : [],
"packaging_shapes_tags" : [
"en:jar",
"en:lid" Corresponding test: # sentence glazen pot + deksel
[
'packaging_text_nl_glazen_pot_met_deksel',
{
lc => "nl",
packaging_text => "1 glazen pot, 1 metalen deksel"
}
], Do you think it's normal ? |
The test result was ok. A glass pot and metal lid should be put into the glasbak (metal is ok). If the test fails, the procesing does not give the required result. |
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
|
|
What
Added the statiegeldblik entry in recyling and logo
Part of