Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase conversion to the Pro Platform by making everything a link #8216

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: increase conversion to the Pro Platform by making everything a link #8216

wants to merge 2 commits into from

Conversation

teolemon
Copy link
Member

What

fix: increase conversion to the Pro Platform by making everything a link

@teolemon
fix: increase-conversion by making everything a link
859341e 
fix: increase-conversion by making everything a link
@teolemon teolemon requested a review from a team as a code owner March 16, 2023 06:53
@github-actions github-actions bot added the Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org label Mar 16, 2023
@teolemon teolemon added 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers 🏭 Producers Platform - acquisition labels Mar 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8216 (859341e) into main (56ff305) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8216   +/-   ##
=======================================
  Coverage   46.99%   46.99%           
=======================================
  Files         104      104           
  Lines       20437    20437           
  Branches     4650     4650           
=======================================
  Hits         9604     9604           
  Misses       9684     9684           
  Partials     1149     1149

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

stephanegigandet
stephanegigandet reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a whole sentence as a link is usually not a good practice, I don't think we should do that.

The links should be underlined though, I'll make another PR to fix the style.

@stephanegigandet stephanegigandet mentioned this pull request Mar 16, 2023
Merged
alexgarel pushed a commit that referenced this pull request Mar 17, 2023
@stephanegigandet
fix: underline links in panel text (#8219)
825f64f 
Links were almost invisible in the text of panels, this PR adds an underline. (related: #8216)

I believe links in general should be more obvious (e.g. with a blue color), but that's for another PR.
@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jun 15, 2023
@github-actions github-actions bot removed the 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers label Nov 9, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet left review comments

@manon-corneille manon-corneille Awaiting requested review from manon-corneille

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🏭 Producers Platform - acquisition ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
🍊 Open Food Facts Server issues
Status: PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teolemon @codecov-commenter @stephanegigandet @manon-corneille