refactor: Content should have some left and right margins in responsive mode #7498 #8098
Conversation
Styles updated for small screen .
There was a problem hiding this comment.
Perfect @Dev-Ashank !
That's so great to see this kind of issue tackled :-)
Thanks. |
scss/_footer.scss
Outdated
| margin-left: 0; | ||
| } | ||
| .title-5 { | ||
| font-size: 1.2857142857rem; |
There was a problem hiding this comment.
Why is this font-size so specific? Have you taken it from somewhere?
There was a problem hiding this comment.
It's already there when I am testing in developer mode in chrome. I should have removed it.
font size removed.
|
For the footer links, there are some sizes where the issue remains:
I think the best way to solve this is just to change this margin: |
| } | ||
| } | ||
|
|
||
| @media #{$small-only} { |
There was a problem hiding this comment.
Those changes might apply to a lot of other p tags elsewhere.
I would prefer to have a local rule like this one:
#contribute_and_discover_links_block {
.inline-list {
margin-left: rem-calc(-17);
}
}
Thanks for reviewing PR and I would update for medium size also . I will always remember to apply local rule as much as possible Thanks for guidance ❤️. |
|
Hi @Dev-Ashank , just wondering if you still plan to work on this PR? Thanks! |
Yes I was waiting for feedback. |
|
Kudos, SonarCloud Quality Gate passed!
|
teolemon
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Styles updated for small screen .
What
Related issue(s) and discussion