-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use JSON::MaybeXS instead of JSON::PP #10578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgarel
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
hangy
approved these changes
Jul 22, 2024
…-server into json-maybexs
One difference is that integers are changed from 0 and 4 to 0.0 and 4.0 in API results:
|
|
This was referenced Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Account deletion
Enabling users to delete account while preserving accountability for edits
API
Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…)
Attributes
https://wiki.openfoodfacts.org/Product_Attributes
🔐 Auth
checkbot
Countries
Data import
Display
🌱 Eco-Score
https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products
✏️ Editing - Auto Suggest
Providing autosuggest for taxonomized fields. Mostly used in editing scenarii
exports
file import
🕹️ Gamification
GS1
The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes.
🍬 How much sugar
https://howmuchsugar.in/ - Mini game powered by Open Food Facts data
🖼️ Images
🥗🔍 Ingredients analysis
https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis
🥗 Ingredients
📖 Knowledge Panels
https://wiki.openfoodfacts.org/Knowledge_panels
lang
👮 Moderation
MongoDB
We have 2 mongodb collections: one for current products, and one for obsolete products
multilingual products
Numbers
🚦 Nutri-Score
📍🏭 Packager codes
https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near-
📦 Packaging
https://wiki.openfoodfacts.org/Category:Recycling
🏭 Producers Platform
https://wiki.openfoodfacts.org/Platform_for_producers
Recent changes
Implemented by @hangy - https://world.openfoodfacts.org/cgi/recent_changes.pl?&page=1&page_size=25
REDIS
Scanbot
🔎 Search
Stores
Tags
🧬 Taxonomies
https://wiki.openfoodfacts.org/Global_taxonomies
🧪 tests
🌐 Translations
update all products
👥 Users
WikiData
We link taxonomies to Wikidata (& back) - https://wiki.openfoodfacts.org/Structured_Data/Wikidata
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we had issues with the JSON::XS module, so we we switched to JSON::PP for safety.
Maybe things work better with Cpanel::JSON::XS, so trying to replace all instances with https://metacpan.org/pod/JSON::MaybeXS (which loads Cpan::JSON::XS or JSON::XS if present)