Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user in pending group when requests to join an org #10500

Merged
merged 7 commits into from
Jul 5, 2024

Conversation

4nt0ineB
Copy link
Collaborator

@4nt0ineB 4nt0ineB commented Jun 26, 2024

What

  • This feature is enabled for validated org
  • The user is added to the 'pending' group of an org when he requests to join it.
  • The org admin can accept or reject.
  • If an other org is requested by the user while waiting for approval, he is removed from the previous one.

Screenshot

Related issue(s) and discussion

@4nt0ineB 4nt0ineB requested a review from a team as a code owner June 26, 2024 16:55
@github-actions github-actions bot added 🧪 tests 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers labels Jun 26, 2024
@github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 👥 Users 🏭 Orgs 🌐 Translations labels Jun 26, 2024
@4nt0ineB 4nt0ineB changed the title feat: add user in pending group when request to join an org feat: add user in pending group when requests to join an org Jun 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 49.27%. Comparing base (dc04d18) to head (a0a3535).
Report is 465 commits behind head on main.

Files Patch % Lines
lib/ProductOpener/Orgs.pm 0.00% 11 Missing ⚠️
lib/ProductOpener/Users.pm 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10500      +/-   ##
==========================================
- Coverage   49.54%   49.27%   -0.28%     
==========================================
  Files          67       76       +9     
  Lines       20650    21863    +1213     
  Branches     4980     5235     +255     
==========================================
+ Hits        10231    10772     +541     
- Misses       9131     9769     +638     
- Partials     1288     1322      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4nt0ineB 4nt0ineB marked this pull request as draft June 27, 2024 13:25
@4nt0ineB 4nt0ineB marked this pull request as ready for review June 28, 2024 11:56
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jul 2, 2024
@github-actions github-actions bot added 💥 Merge Conflicts 💥 Merge Conflicts and removed 💥 Merge Conflicts 💥 Merge Conflicts labels Jul 2, 2024
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@4nt0ineB 4nt0ineB merged commit 6065aec into openfoodfacts:main Jul 5, 2024
12 checks passed
@4nt0ineB 4nt0ineB deleted the pending-group-org-member branch July 12, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 Merge Conflicts 💥 Merge Conflicts 🏭 Orgs 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests 🌐 Translations 👥 Users
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create a new "pending" group of organization members
3 participants