refactor: global variables removal #10474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
API
4nt0ineB
changed the title
github-actions
bot
added
API WRITE
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10474 +/- ##
==========================================
- Coverage 49.54% 49.30% -0.24%
==========================================
Files 67 76 +9
Lines 20650 21838 +1188
Branches 4980 5231 +251
==========================================
+ Hits 10231 10768 +537
- Misses 9131 9750 +619
- Partials 1288 1320 +32 ☔ View full report in Codecov by Sentry. |
stephanegigandet
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The goal is to get rid of the global variables as suggested by the various 'Todo' in the code, to limit side effects.
These will be accessed through
$request_ref:$admin$styles$initjs$cc$bodyaboutAbout
$lcand$countryI'm not sure if I it's a good idea. For a part I can easily apply the same thing as for the other ones, because it's just a matter of putting them in therequest_ref(in the .pl cgi). But for the rest, they are used at a very nested level in the call stack. I'd have to add one or two params to many functions to get to them, and where they are called also. It's not unfeasible though.