fix: update paths for EAN8 and short barcodes (padding with zeroes) - DO NOT MERGE #10472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgarel
reviewed
Jun 21, 2024
There was a problem hiding this comment.
can we put it in a migration sub folder ?
There was a problem hiding this comment.
yes, I will move it
stephanegigandet
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I closed the very old PR #3915 and I am opening this new one to put it on the first page.
Original issue: #3818
We will need to move the file structures on all flavors (OFF, OBF, OPF, OPFF) roughly at the same time, as otherwise we will have issues if some products are moved from one flavor to another.
So the migration script is using "old" conventions so that it can run on the old obf / opf / opff code (without needing newer modules).
The migration script is first used to assess the situation (how many products would be moved, how many products have conflicts etc.) on all flavors.
PR in infrastructure repo to detail the migration: openfoodfacts/openfoodfacts-infrastructure#363