-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: opposite categories #10392
chore: opposite categories #10392
Conversation
This should be temporary. Is more an exclusive characteristic.
skimmed, semi-skimmed and whole
Great! To go further, could you explain deeper the "exclusive" characteristic? What I understand is that an "exclusive" category means that the product can't have another category than itself and its parents. But could you also provide an example of a category that is NOT exclusive? Regarding to the list here, could you make two lists: one containing the opposites and one containing the exclusives? |
We could add tests:
|
The final categories (leaves/end points) should be exclusive. A product can not belong to multiple leaves, for instance a meat can not be a fish nor a black pepper. A leaf category can have multiple parents, for instance skimmed milk can belong to pasteurised milks and homogenised milks. |
|
@@ -1141,6 +1164,7 @@ hr:Pića i pripravci za piće | |||
it:Bevande e preparati per bevande | |||
nl:Dranken en drankbereidingen | |||
description:en:This mixes ready to drink beverages and not-ready to drink beverages | |||
opposite:en: en:meals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opposite of "Beverages" would be "Food" I think, not "meals". Of course that would mean putting most parent categories under "Food"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment for beverages vs meals. Otherwise it looks good to me. I think we could try it, and add some data quality warnings based on it, to see what product it flags, and then we could adjust.
What
Adding opposite characteristics to categories, as discussed in the data quality meeting. Based on the list on https://wiki.openfoodfacts.org/Data_quality_missions.
Some on the list are not included as these are better designated by the characteristic exclusive (can not be combined with another category)..