Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Add FlagKey as prometheus label in eval counter #55

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

glutamatt
Copy link
Contributor

usefull for human friendly dashboards

usefull for human friendly dashboards
@codecov-commenter
Copy link

Codecov Report

Merging #55 (f9c2f02) into main (1694d8e) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   81.55%   81.51%   -0.04%     
==========================================
  Files          27       27              
  Lines        2174     2175       +1     
==========================================
  Hits         1773     1773              
- Misses        314      315       +1     
  Partials       87       87              
Impacted Files Coverage Δ
pkg/handler/eval.go 86.41% <0.00%> (-0.36%) ⬇️
pkg/config/config.go 78.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1694d8e...f9c2f02. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit 8e62c17 into openflagr:main Nov 22, 2021
@glutamatt glutamatt deleted the evalpromflagkey branch November 22, 2021 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants