Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Autogenerated documentation site #274

Closed
wants to merge 1 commit into from
Closed

[WIP] Autogenerated documentation site #274

wants to merge 1 commit into from

Conversation

johnmccabe
Copy link
Contributor

@johnmccabe johnmccabe commented Oct 10, 2017

Signed-off-by: John McCabe [email protected]

Description

Raising a WIP PR for the autogeneration of the documentation site. This includes both the autogeneration of the site, and also some moving, restructuring and updates to the current content in order to make the resulting site flow more cleanly and to fill out gaps/remote redundancy and repetition (the bit that involves work).

The current implementation goes with mkdocs with the material theme, with a custom monochrome logo, some light styling to the logo css and custom colour to match the openfaas.com site.

The WIP site is being deployed from the PR branch from my fork via Travis, it can be seen here:

screen shot 2017-10-10 at 01 27 17

Motivation and Context

How Has This Been Tested?

Testing for this is pending, we'll likely need the following

  • Proof read by @alexellis for feedback on structure/content
  • Autogeneration of docs from a fork to a custom domain

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@open-derek
Copy link

open-derek bot commented Nov 3, 2017

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@open-derek open-derek bot added the no-dco label Nov 3, 2017
@alexellis
Copy link
Member

Pushing up WIP early, DO NOT MERGE
?

@alexellis
Copy link
Member

alexellis commented Nov 6, 2017

Hi John, the template for this looks really good and it's really useful to have the Travis instructions or building the site, too.

I'm thinking of the documentation sitting in its own repository so it is self-contained.

I'm not sure if I've seen the roadmap etc brought into a docs site. I'll check what Docker and Kubernetes are doing who I know are an inspiration for our project.

@ericstoekl
Copy link
Contributor

@alexellis I've taken these changes and merged them to the latest commit in master here:

https://github.com/ericstoekl/faas/tree/markdown-docs

Should we create a new PR for this? What still needs to be done for this PR?

@alexellis
Copy link
Member

@johnmccabe didn't sign all the commits off for this documentation site. Also the docs have progressed since this PR was opened 2 months ago so we'd need to check we are in sync. Not sure what the best option is for moving forward at this point.

@derek derek bot removed the no-dco label Dec 18, 2017
@johnmccabe
Copy link
Contributor Author

@alexellis / @ericstoekl I've squashed and signed the WIP commits - have not touched the rebase to make the outstanding changes more visible.

@johnmccabe
Copy link
Contributor Author

johnmccabe commented Dec 19, 2017

Main guts of this change in its current state are as follows:

  • CI build/deploy to GH pages via Travis
  • Mkdocs docker based build
  • The main changes were around an attempt to restructure the docs layout, primarily on the getting statrted flows - the K8s/Docker/PWD deploy guides were tweaker, and then getting started flow was broken into step sections, thats as far as I'd gotten to before I'd dropped offline - step 1 is ok, step 2 onwards were placeholders containing the original doc contents - effectively as a cache of original content that would be moved if necessary to other/new docs (at no point during the process did I want existing info to be removed from the repo).

To continue this would involve picking up on this getting started section, then some presentation updates around the guides sections etc to give a logical flow to them.

@alexellis the very long build time (17min+) appeared to be blips on the Travis side (occuring once) - builds times range from ~44sec to ~3minutes with the bulk of the time actually in the deploy step to GH Pages (the Travis logs suggest that the site build takes ~7sec consistently across all builds, its the docker run --rm -it -v $PWD:/docs squidfunk/mkdocs-material build --verbose --clean --strict step in the logs). You can have a look at the builds here - https://travis-ci.org/johnmccabe/faas/builds/

@johnmccabe
Copy link
Contributor Author

johnmccabe commented Dec 19, 2017

Important

The .travis.yml has been updated to just build the docs - this is a temporary step, and the doc build/deploy step would be merged into the config on master before considering a merge.

@alexellis
Copy link
Member

@ericstoekl you said you'd re-based this? Is there a PR?

@ericstoekl
Copy link
Contributor

ericstoekl commented Dec 29, 2017 via email

@johnmccabe
Copy link
Contributor Author

Closing as @ericstoekl is picking this up in #464

@johnmccabe johnmccabe closed this Jan 7, 2018
@alexellis
Copy link
Member

ack @johnmccabe - feel free to input into #464 with Eric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants