Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Revert "Fix: OpenEMR logs sensitive information such as payment details (#7341)" #7396

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix: Revert "Fix: OpenEMR logs sensitive information such as payment details (#7341)" #7396

merged 1 commit into from
Apr 26, 2024

Conversation

bradymiller
Copy link
Sponsor Member

Turns out probably shouldn't mess with log information to ensure remain compatible with ONC certification.

@bradymiller
Copy link
Sponsor Member Author

bradymiller commented Apr 23, 2024 •
edited
Loading

@adunsulag , @stephenwaite ,
I was not able to find obvious language in the ONC certification that stated unable to modify things while logging them, however there was language about not modifying things that have already been logged. Since not clear, seems reasonable to just not mess with things while they are logged. Note when we are inserting sensitive things like credentials or checking credentials, we use a sql function that skips logging (so we have a mechanism to deal with when running queries that contain information that should not be logged).

@bradymiller bradymiller merged commit 1d0e579 into openemr:master Apr 26, 2024
25 checks passed
bradymiller added a commit to bradymiller/openemr that referenced this pull request Apr 26, 2024
@bradymiller
Fix: Revert "Fix: OpenEMR logs sensitive information such as payment …
6c57d1b 
…details (openemr#7341)" (openemr#7396)

This reverts commit 9be12b8.
@bradymiller
Copy link
Sponsor Member Author

also will revert this in rel-702

@bradymiller bradymiller mentioned this pull request Apr 26, 2024
Merged
bradymiller added a commit that referenced this pull request Apr 26, 2024
@bradymiller
Fix: Revert "Fix: OpenEMR logs sensitive information such as payment …
a1ce0a5 
…details (#7341)" (#7396) (#7410)

This reverts commit 9be12b8.
sjpadgett added a commit to sjpadgett/openemr that referenced this pull request May 7, 2024
@sjpadgett
Merge branch 'master' of https://github.com/openemr/openemr into weno…
631b69f 
…_last

* 'master' of https://github.com/openemr/openemr:
  Hide dashboard card 2 (openemr#7423)
  fix: ccda zip import and php warnings and deprecations (openemr#7416)
  Fee sheet and Codes revenue code (openemr#7415)
  Refactor UB04 837i X12 feature to make work again. (openemr#7412)
  feat: support loop 2420E (openemr#7405)
  Fix: Revert "Fix: OpenEMR logs sensitive information such as payment details (openemr#7341)" (openemr#7396)
  Weno better error handling from fetches (openemr#7408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adunsulag adunsulag adunsulag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bradymiller @adunsulag