add print button and put patient's details at top of visit history page #7270 #7359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adunsulag
reviewed
Apr 22, 2024
| @@ -401,7 +422,7 @@ function changePageSize() { | |||
|
|
|||
| $countRes = sqlStatement($countQuery, $sqlBindArray); | |||
| $count = sqlFetchArray($countRes); | |||
| $numRes = $count['c']; | |||
| $numRes += $count['c']; | |||
There was a problem hiding this comment.
It looks like this didn't actually change the code logic, was thinking it did, but on further examination it keeps the code the same.
There was a problem hiding this comment.
oh yes, apologies: - i've been working on this code to sort out the problems where the documents are displayed on every page, issue #7275, and this new line has crept in from that work. It's not needed simply to add the print functionality. I'll fix the new PR
adunsulag
reviewed
Apr 22, 2024
| @@ -297,6 +308,16 @@ function changePageSize() { | |||
| </span> | |||
|
|
|||
| <br /> | |||
| <span class="heading" > | |||
| <?php | |||
| // RM put patienes name, id and dob at top of the history --> | |||
There was a problem hiding this comment.
This breaks if the attendant_type is not a patient (IE therapy group encounters are being viewed. We need to surround all of this:
if ($attendant_type == 'pid') {
attendant_type in this PR was not accounted for in the patient / dob display.
Removed unused class reference.
adunsulag
approved these changes
Apr 22, 2024
|
thank you so much stephen - i was just fixing these for a new PR when i noticed you'd done it already :-) |
sjpadgett
pushed a commit
to sjpadgett/openemr
that referenced
this pull request
Apr 22, 2024
…age openemr#7270 (openemr#7359) * add print button and put patient's details at top of visit history page * add comment to say it fixes issue openemr#7270 * fix styling errors in PR * fix styling errors in PR * fix styling errors in PR * Update encounters.php to handle attendant_type attendant_type in this PR was not accounted for in the patient / dob display. * Update encounters.php remove unused class reference Removed unused class reference. --------- Co-authored-by: Stephen Nielson <[email protected]> (cherry picked from commit 2500b2c)
bradymiller
reviewed
Apr 23, 2024
| $name = getPatientNameFirstLast($pid); | ||
| $dob = text(oeFormatShortDate(getPatientData($pid, "DOB")['DOB'])); | ||
| $external_id = getPatientData($pid, "pubpid")['pubpid']; | ||
| echo $name . " (" . $external_id . ")" . " DOB: " . $dob ; |
There was a problem hiding this comment.
need escaping:
echo text($name ). " (" . text($external_id) . ")" . " DOB: " . $dob ;
ruthkonyn
added a commit
to ruthkonyn/openemr
that referenced
this pull request
Apr 23, 2024
This was referenced Apr 23, 2024
sjpadgett
pushed a commit
that referenced
this pull request
May 26, 2024
sjpadgett
added a commit
to sjpadgett/openemr
that referenced
this pull request
May 26, 2024
…_last_minute * 'master' of https://github.com/openemr/openemr: escape strings - brady's comment on pr openemr#7359 (openemr#7400) Added fix for zip bomb (openemr#7407) Phantom date showing at the top of all reports. (openemr#7433) feat: show collection balance in billing widget (openemr#7454)
sjpadgett
pushed a commit
to sjpadgett/openemr
that referenced
this pull request
May 26, 2024
(cherry picked from commit 7febeb9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7270
Short description of what this resolves:
to print or make a pdf of a visit history report one had to use the browsers print function, with ctrl+p or file/print etc. This only prints what had been displayed on the screen, so for a long history that takes several screens only the first would be printed.
Changes proposed in this pull request:
add a 'print' button that prints the complete page of the history being displayed. for page length 'ALL' this is the complete history which will produce a multi page document where necessary
display the patient's details at the top of the history window and on the first page of the print or pdf document.