Weno follow up #7196
Weno follow up #7196
Conversation
- correct interval for WenoExchange - add after actions to enable, disable and delete background tasks.
|
@dataengr More changes you may want to note. |
…_followup * 'master' of https://github.com/openemr/openemr: fix: support multiple modifiers in fee sheet (openemr#7166) feat: use global default visit category for add edit event (openemr#7190)
- find and populate user id to prescription table. - remove encounter dependency to render weno prescription frame. - add docblocks - restore README module install instruction.
There was a problem hiding this comment.
I see that you dropped this file in the root of the module. I have read the entire file. I understand most of what it is doing. Is the pattern for the future of module building?
There was a problem hiding this comment.
only if needed to do specific module manager actions like remove a global when module is disabled etc.
There was a problem hiding this comment.
So, for my first use of this feature, I will be adding it to the quest lab module.
https://github.com/juggernautseinc/oe-quest-lab-hub
It has pieces that would need to be removed from background services and global.
There was a problem hiding this comment.
How do I get a module code review? @bradymiller
- remove encounter requirement my call - fix user specific password get - remove weno from custom menu.
| @@ -12,6 +12,7 @@ | |||
| use OpenEMR\Modules\WenoModule\Services\WenoPharmaciesJson; | |||
|
|
|||
| if (isset($_GET['key']) && !empty(isset($_GET['key']))) { | |||
| // called from old v6.0.0 requirement. | |||
There was a problem hiding this comment.
I think what Brady was getting at is that the script can't be left without any protection like if running from cli?
There was a problem hiding this comment.
I don't think so and is fine
There was a problem hiding this comment.
but anyone could hit this file with a get request key param and start weno?
|
Merging soon. If anyone has any further issue then by all means be my guess and change. @dataengr
|
- remove tasking call for old background tasks.
|
okay @dataengr Removed what I think is old left behinds for old weno feature and I see no usage by module but correct me if im wrong. |
| $logsync = new LogProperties(); | ||
| $logsync->logSync(); | ||
| } | ||
|
|
||
| function downloadWenoPharmacy() |
There was a problem hiding this comment.
fare thee well start_weno() :)
|
@sjpadgett, the method start_weno is no longer in use. |
|
it was a function and I removed it |
|
I think I did pretty good to make this module whole and clean. I'm sending back to @omegasystemsgroup to follow up with testing and any bug fixes I caused by making whole for openemr or otherwise missed in my testing which I wasn't charged with. |
|
|
Fixes #
Short description of what this resolves:
Changes proposed in this pull request: