fix: fix cdr gui alert toggles #7179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
testing well |
bradymiller
commented
Jan 20, 2024
| @@ -498,6 +498,9 @@ function updateSummary($ruleId, $types, $title, $developer, $funding, $release, | |||
| { | |||
| $rule = $this->getRule($ruleId); | |||
|
|
|||
| // if $types is empty, then set to empty array so the in_array() calls below will work | |||
| $types = !empty($types) ? $types : []; | |||
There was a problem hiding this comment.
actually, i think i can just use the elvis operator
hanksterr7
reviewed
Jan 20, 2024
There was a problem hiding this comment.
Confirming that with
$types = $types ?: [];
the error I originally observed is resolved.
Thanks for enlightening me about the Elvis operator :)
I originally thought the name came from returning an empty array (related to Elvis has left the building). More correctly, it relates to ?: looking like Elvis when turned sideways
bradymiller
added a commit
that referenced
this pull request
Jan 25, 2024
|
I just brought this fix into rel-702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7178