Openemr fix telehealth signup locale #6413

adunsulag · 2023-04-26T00:19:16Z

Fixed up the verbiage and some problems with the telehealth live payment signup process. It was popping up an alert box with the paypal subscriber id and expected the patient to copy and remember that value for signup. This is most likely what was causing the multiple signup problems that users of the module were dealing with.

Broke the signup into three steps and provide progress status to the users as they signup. Better instructions on how to move to the next step are included in each process.

Added a check for the locale settings which should be setup to avoid clinic problems. Added instructions that the user needs to log out and log back in after saving the telehealth settings.

Include instructions and the subscription id for the user to use when they signup for the credentials. Add a copy button and switch the alert of the subscription id to actually show up in a success message info box. Before the change the user had limited understanding on how to proceed to the next steps in the configuration system.

To make the signup process easier for users, we break the signup into three steps with instructions. We also add saving the paypal subscription id so we can check if the paypal process has already completed and been signed up. We show progress to the user as they signup.

Fixed the paypal key coming back from Sherwin to be the right key value. Fixed the conditions on the subscription id.

sjpadgett · 2023-04-26T00:42:43Z

interface/modules/custom_modules/oe-module-comlink-telehealth/welcome.php

+use Comlink\OpenEMR\Modules\TeleHealthModule\Bootstrap;
+use Comlink\OpenEMR\Modules\TeleHealthModule\TelehealthGlobalConfig;
+
+$kernel = $GLOBALS['kernel'];
+$bootstrap = new Bootstrap($kernel->getEventDispatcher(), $kernel);
+$globalConfig = $bootstrap->getGlobalConfig();
+$subscriptionId = $globalConfig->getGlobalSetting(TelehealthGlobalConfig::COMLINK_TELEHEALTH_PAYMENT_SUBSCRIPTION_ID) ?? '';
+$isCoreConfigured = $globalConfig->isTelehealthCoreSettingsConfigured() === true;


sjpadgett · 2023-04-26T00:44:12Z

interface/modules/custom_modules/oe-module-comlink-telehealth/src/TelehealthGlobalConfig.php

+ // timezone is not set in the $GLOBALS array oddly, not sure why, check against the database
+ $record = QueryUtils::fetchRecords("SELECT gl_name, gl_index, gl_value FROM globals WHERE gl_name=?", [self::LOCALE_TIMEZONE]);


Yes I've seen this and meant to track it down.

I know where it's occurring, just thought that might have been intentional. Didn't want to change anything in the globals though so close to the wire here so I just check against globals.

sjpadgett · 2023-04-26T00:49:32Z

interface/modules/custom_modules/oe-module-comlink-telehealth/moduleConfig.php

+ $items[TelehealthGlobalConfig::COMLINK_VIDEO_REGISTRATION_API] = $credentials['registrationUri'];
+ $items[TelehealthGlobalConfig::COMLINK_VIDEO_TELEHEALTH_API] = $credentials['videoApiUri'];
+ $items[TelehealthGlobalConfig::COMLINK_VIDEO_API_USER_ID] = $credentials['ctsiOrgUid'];
+ $items[TelehealthGlobalConfig::COMLINK_VIDEO_API_USER_PASSWORD] = $cryptoGen->encryptStandard(trim($credentials['ctsiOrgPwd']));
+ $items[TelehealthGlobalConfig::COMLINK_VIDEO_TELEHEALTH_CMS_ID] = $credentials['ctsiOrgId'];
+ $items[TelehealthGlobalConfig::COMLINK_TELEHEALTH_PAYMENT_SUBSCRIPTION_ID] = $credentials['paypal_subscription_id'] ?? null;
 // Save to globals table.


Recommend these default to empty string if undefined so exception won't get thrown by sequel engine for writing null values to this table.
Or put a null key/value check in foreach.
Sorry I missed that in my commits.

I'm testing this on my test jig for pass through of new array key from server.
Will let ya know

adunsulag · 2023-04-26T01:55:00Z

@sjpadgett if this is working well, we can bring this in and I'll submit a PR for 7.0.1

sjpadgett · 2023-04-26T02:02:45Z

My change to sign up application was just one line to the src/Action/Credentials/RequestCredentialAction.php on Sherwins git project. I also fix autocomplete to be off in credentials twig.
The change:

if ($this->data['credentials']) {
            $args = json_decode($newCredentials, true);
            self::saveCustomerCredentials(
                $this->repository,
                $this->customerValidator,
                $this->logerFactory
            );
            // So module can reference as needed.
            $args['ctsiVBData']['paypal_subscription_id'] = $this->data['paypal_subscription_id'];
            return $this->twig->render($response, 'displaycredentials.twig', $args);
        }

So with this PR and bypassing the paypal api request in my test jig it works.
I say @juggernautsei needs to update and test this in v7.0.1 we'll be releasing.

Go ahead and bring in if you're ready

sjpadgett

Great job especially I like the copy/paste you added.

* Add save and locale telehealth check instructions Added a check for the locale settings which should be setup to avoid clinic problems. Added instructions that the user needs to log out and log back in after saving the telehealth settings. * Fix psr problems. * Fix telehealth subscription signup. Include instructions and the subscription id for the user to use when they signup for the credentials. Add a copy button and switch the alert of the subscription id to actually show up in a success message info box. Before the change the user had limited understanding on how to proceed to the next steps in the configuration system. * Improve signup verbiage, add subscription id To make the signup process easier for users, we break the signup into three steps with instructions. We also add saving the paypal subscription id so we can check if the paypal process has already completed and been signed up. We show progress to the user as they signup. * Fix if conditions, paypal key Fixed the paypal key coming back from Sherwin to be the right key value. Fixed the conditions on the subscription id. * Include the free verbiage in the description. * Updated telehealth plan for 14 day free trial. * Defaulting values to avoid sql error.

bradymiller · 2023-04-26T04:19:17Z

* Add save and locale telehealth check instructions Added a check for the locale settings which should be setup to avoid clinic problems. Added instructions that the user needs to log out and log back in after saving the telehealth settings. * Fix psr problems. * Fix telehealth subscription signup. Include instructions and the subscription id for the user to use when they signup for the credentials. Add a copy button and switch the alert of the subscription id to actually show up in a success message info box. Before the change the user had limited understanding on how to proceed to the next steps in the configuration system. * Improve signup verbiage, add subscription id To make the signup process easier for users, we break the signup into three steps with instructions. We also add saving the paypal subscription id so we can check if the paypal process has already completed and been signed up. We show progress to the user as they signup. * Fix if conditions, paypal key Fixed the paypal key coming back from Sherwin to be the right key value. Fixed the conditions on the subscription id. * Include the free verbiage in the description. * Updated telehealth plan for 14 day free trial. * Defaulting values to avoid sql error.

adunsulag added 5 commits April 25, 2023 18:58

Add save and locale telehealth check instructions

cfd2b8a

Added a check for the locale settings which should be setup to avoid clinic problems. Added instructions that the user needs to log out and log back in after saving the telehealth settings.

Fix psr problems.

360486e

Fix if conditions, paypal key

84383fa

Fixed the paypal key coming back from Sherwin to be the right key value. Fixed the conditions on the subscription id.

adunsulag requested a review from sjpadgett April 26, 2023 00:19

Include the free verbiage in the description.

81a3677

sjpadgett reviewed Apr 26, 2023

View reviewed changes

adunsulag added 2 commits April 25, 2023 20:51

Updated telehealth plan for 14 day free trial.

04d6c49

Defaulting values to avoid sql error.

fce315f

adunsulag merged commit aee650a into openemr:master Apr 26, 2023
22 checks passed

sjpadgett approved these changes Apr 26, 2023

View reviewed changes

adunsulag deleted the openemr-fix-telehealth-signup-locale branch April 5, 2024 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Openemr fix telehealth signup locale #6413

Openemr fix telehealth signup locale #6413

adunsulag commented Apr 26, 2023

sjpadgett Apr 26, 2023

sjpadgett Apr 26, 2023

adunsulag Apr 26, 2023

sjpadgett Apr 26, 2023

adunsulag Apr 26, 2023

adunsulag commented Apr 26, 2023

sjpadgett commented Apr 26, 2023

sjpadgett left a comment

bradymiller commented Apr 26, 2023

		// timezone is not set in the $GLOBALS array oddly, not sure why, check against the database
		$record = QueryUtils::fetchRecords("SELECT gl_name, gl_index, gl_value FROM globals WHERE gl_name=?", [self::LOCALE_TIMEZONE]);

Openemr fix telehealth signup locale #6413

Openemr fix telehealth signup locale #6413

Conversation

adunsulag commented Apr 26, 2023

sjpadgett Apr 26, 2023

Choose a reason for hiding this comment

sjpadgett Apr 26, 2023

Choose a reason for hiding this comment

adunsulag Apr 26, 2023

Choose a reason for hiding this comment

sjpadgett Apr 26, 2023

Choose a reason for hiding this comment

adunsulag Apr 26, 2023

Choose a reason for hiding this comment

adunsulag commented Apr 26, 2023

sjpadgett commented Apr 26, 2023

sjpadgett left a comment

Choose a reason for hiding this comment

bradymiller commented Apr 26, 2023