add qrda encounter dedupe merge #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bradymiller
reviewed
May 21, 2022
| echo "<br />$sql"; | ||
| $sql = "UPDATE " . escape_table_name($table['encounter_table']) . " SET " . | ||
| escape_sql_column_name($table['encounter_column'], array($table['encounter_table'])) . " = ? WHERE " . | ||
| escape_sql_column_name($table['encounter_column'], array($table['encounter_table'])) . " = ?"; |
bradymiller
reviewed
May 21, 2022
| ); | ||
| sqlStatement($sql, array($target, $source['encounter'])); | ||
| if ($GLOBALS['adodb']['db']->_connectionID->affected_rows) { | ||
| echo "<br />$sql ($target)" . ($source['encounter']); |
There was a problem hiding this comment.
would prob html escape these 2 variables
- If end date the mustache resolves to RelevantPeriod low high else RelevantDateTime fix observation form to save null on empty end dates
|
After these changes things are going much better. Deduplication has a few rules that I'll try to acknowledge in the UI:
|
|
It took 4.5 minutes to test CMS127 with 20 patients start to finish. So each patient takes 1.8 sec import and maybe 10secs for cypress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5364
Short description of what this resolves:
This will get us by with testing I believe. I'll know more when I run through all the test patients, again!