fixes CQM source of payment for ins search #5350
Conversation
| @@ -1158,9 +1158,7 @@ class='text'>(<?php echo xlt('Browse'); ?>)</a> | |||
| var fval = $('#form_' + flds[i]).val(); | |||
| duplicateFieldsArray['#form_' + flds[i]] = fval; | |||
| } | |||
| $(".sel2").select2({ | |||
| <?php require($GLOBALS['srcdir'] . '/js/xl/select2.js.php'); ?> | |||
| }); | |||
There was a problem hiding this comment.
pretty sure this require is satisfied when select2 is brought in with the core header
There was a problem hiding this comment.
Select2 may have several instances each requiring its own library. That's why you see the way it is. So this is a no no!:)
There was a problem hiding this comment.
Also may have different setups.
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't understand. You're removing the lines the permalink points to. What you're doing is removing the class link to select2 and the translations. Where is the class sel2 already inited?
There was a problem hiding this comment.
I see your confusion. Each instance of select2 needs the translations pulled in by the required. Otherwise the select2 defaults untranslated would be used plus, all the html tags where the sel2 class is used prob won't work.
There was a problem hiding this comment.
ok, I'll revert and start another issue for it, try to figure out why that is breaking the returned entry from appearing in the select label
There was a problem hiding this comment.
Most likely the styling. I noticed this is the only select2 that is not using the bootstrap stylings. Checkout one of my select2's and emulate setup.
I should have done that when I was putting in the new ones. The one we are looking at was the only select2 when I put in the others. It has been there for awhile.
There was a problem hiding this comment.
do you have a screen shot of issue?
There was a problem hiding this comment.
Thinking about it @stephenwaite , do we need select2 for the two places it is used(sel2 class that is). It was put in for searching
sql/6_1_0-to-7_0_0_upgrade.sql
Outdated
| INSERT INTO list_options ( list_id, option_id, title, seq, is_default ) VALUES ('order_type','order','Order',90,0); | ||
| #EndIf |
There was a problem hiding this comment.
needs new line at end of file. There are several reason for this one being it helps ensure our upgrade parser get the last item. Most times it may work but, I wouldn't count on it!
| @@ -256,7 +257,8 @@ public function insert($data) | |||
| $data["ins_type_code"], | |||
| $data["x12_receiver_id"], | |||
| $data["x12_default_partner_id"] ?? '', | |||
| $data["alt_cms_id"] | |||
| $data["alt_cms_id"], | |||
| $data["cqm_sop"] ?? null, | |||
There was a problem hiding this comment.
Looks like a new column. If so, Do I need to change import destination for payer. Also payer cqm service.
There was a problem hiding this comment.
okay. please remind me when merged.
| $(".sel2").select2({ | ||
| <?php require($GLOBALS['srcdir'] . '/js/xl/select2.js.php'); ?> | ||
| }); |
There was a problem hiding this comment.
Could try:
$(".sel2").select2({
theme: "bootstrap4",
dropdownAutoWidth: true,
width: 'resolve',
<?php require($GLOBALS['srcdir'] . '/js/xl/select2.js.php'); ?>
});
There was a problem hiding this comment.
works like a champ 🥊
pushed it to #5352 and now passing cms147v11
|
@stephenwaite Are we okay on licensing on this https://github.com/openemr/openemr/pull/5350/files#diff-506f53abf55f1b6a8944c6c5042520a5d630b24a5c108d4f89b5bae12d013c35 i.e. contrib/cqm_valueset/ep_ec_only_cms_20210506.xml.zip |
|
thanks @sjpadgett , just removed it |
Fixes #5349
Short description of what this resolves:
fixes above issue
also restores ability to search by fixing SQL query that failed to match if no phone number was entered for an insurance
also fixes
ct_keyin database.sql and reverts the change made in find_code_popup.php to circumventalso adds
ordertoorder_typesfor QRDA I Procedure performedChanges proposed in this pull request: