Fix lang issue at disclosure_full file #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradymiller
reviewed
Mar 5, 2017
| @@ -145,7 +145,7 @@ class='css_button_small iframe' onclick='top.restoreSession()'><span><?php echo | |||
| <a href='#' class='deletenote css_button_small' | |||
| id='<?php echo text($iter{id}); ?>' onclick='top.restoreSession()'><span><?php echo xlt('Delete');?></span></a></td> | |||
| <td class="text" valign='top'><?php echo text($iter{recipient});?> </td> | |||
| <td class='text' valign='top'><?php if($event[1]=='healthcareoperations'){ echo xlt('health care operations'); } else echo text($event[1]); ?> </td> | |||
| <td class='text' valign='top'><?php if($event[1]=='healthcareoperations'){ echo xlt('health care operations'); } else echo xlt(text($event[1])); ?> </td> | |||
There was a problem hiding this comment.
the correct way to do this would be the following:
<td class='text' valign='top'><?php echo text(getListItemTitle('disclosure_type',$event[1])); ?> </td>
Note this function is here: https://github.com/openemr/openemr/blob/master/library/options.inc.php#L3094
So, you also need to require_once the options.inc.php at top of this script for it to work.
|
review complete. see issue, which should be simple to address. |
|
Hi, i improved the code according to your recommendations |
|
looked good to brought into the codebase. thanks for the fix! -brady |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi this is the fix lang issue