Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8mb4 support #3721

Merged
merged 1 commit into from
Jul 14, 2020
Merged

utf8mb4 support #3721

merged 1 commit into from
Jul 14, 2020

Conversation

bradymiller
Copy link
Sponsor Member

@bradymiller bradymiller commented Jul 5, 2020

Initial testing is good. Still a bunch more testing to do:

  1. On all 8 mysql/mariadb version (UPDATE: now just six :) ) DONE
  2. Ensure backward compatible for upgraders DONE
  3. Ensure actually working in all contexts (core, calendar, gacl, doctrine, portal, zend) DONE

@bradymiller bradymiller self-assigned this Jul 5, 2020
@bradymiller bradymiller added this to the 6.0.0 milestone Jul 5, 2020
@bradymiller
Copy link
Sponsor Member Author

bradymiller commented Jul 6, 2020

Looks like mariadb 10.1 and mysql 5.6 have rather strict key size limits which are gonna require some effort to fix. Thinking best option is to drop support for mariadb 10.1 and mysql 5.6 since they are at end of life in 10/2020 and 2/2021 respectively anyways.

@bradymiller
Copy link
Sponsor Member Author

bradymiller commented Jul 7, 2020

just a quick example of what utf8mb4 allows (emoticons in messages):

image

turns out utf8(which is utf8mb3) is limited since only uses 3 bytes, whereas pure utf8 should have 4 bytes (utf8mb4) and then allows many more characters (including some chinese characters missing from utf8mb3 and emoticons and bunch of other characters).

@tywrenn
Copy link
Contributor

tywrenn commented Jul 14, 2020

@bradymiller I enabled system emoticons through SCSS -- didn't realize that this was also a required step 😂

@bradymiller
Copy link
Sponsor Member Author

bradymiller commented Jul 14, 2020

testing well and bringing this in (along with companion docker and demofarm changes). hopefully will not have to think about character sets and collations again for another 8 years :)

@bradymiller bradymiller merged commit f3e014d into openemr:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants