Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function() standardize #3173

Merged
merged 2 commits into from
Mar 17, 2020
Merged

function() standardize #3173

merged 2 commits into from
Mar 17, 2020

Conversation

bradymiller
Copy link
Sponsor Member

@bradymiller bradymiller commented Mar 17, 2020 •
edited
Loading

@stephenwaite and @stu01509 ,
Followed @stu01509 recs on the prior PR(#3171).
Couldn't pass up the opportunity to modify 157 files :)

@stu01509
Copy link
Member

Hi @bradymiller and @stephenwaite

I am happy to hear this,
Because in default ESLint rules, It recommends using $(function () {
So It's a good beginning 👍

@bradymiller
Copy link
Sponsor Member Author

bradymiller commented Mar 17, 2020 •
edited
Loading

done.
also found some more renegades ($( function), so now up to 227 files :)

@bradymiller
Copy link
Sponsor Member Author

passing travis and bringing. a win for ESLint :)

@bradymiller bradymiller merged commit dd47a41 into openemr:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bradymiller @stu01509