Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages to multiple patients #1132

Merged

Conversation

shachar058
Copy link
Contributor

@shachar058 shachar058 commented Oct 17, 2017

Hi Brady,
This addition enables the user to send a message to multiple patients (and acts pretty much like sending to multiple users which is an existing feature).
Everything is supposed to work the same besides for being able to send to multiple patients.

thanks,
shachar

(below added by bradymiller)
demo is here:
https://www.open-emr.org/wiki/index.php/Development_Demo#Lambda_-_Up_For_Grabs_Demo

@bradymiller
Copy link
Sponsor Member

This feature can be tested on the following Up For Grabs demo:
https://www.open-emr.org/wiki/index.php/Development_Demo#Lambda_-_Up_For_Grabs_Demo

@shachar058
Copy link
Contributor Author

@bradymiller
I'm not sure what you mean...
Do you want me to test it on that environment?
When I go to the link https://four.openemr.io/h/openemr it gives me 502 bad gateway. Is this the link I'm meant to use?

@bradymiller
Copy link
Sponsor Member

bradymiller commented Oct 19, 2017

Nope, the Up For Grab demos are just meant for other folks that want to test out this feature(without needing to install it locally).
Demos all reset at 1:00 pacific time and takes about 15 minutes which is why it didn't work for you. It's now working.

@bradymiller bradymiller self-assigned this Oct 19, 2017
$reply_to = $_POST['reply_to'];

//Need to do this because sometimes there will be multiple patients separated by semicolon, sometimes 1 patient with semicolon, and sometimes 1 patient without semicolon
if (strpos($_POST['reply_to'], ';') !== false){
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this only supposed to be true if the semicolon is at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, changed it to rtrim

@bradymiller
Copy link
Sponsor Member

@shachar058 ,
How is your group using patient messaging? Are you using the offsite patient portal or a custom module?
-brady

@shachar058
Copy link
Contributor Author

@bradymiller
Currently we aren't using messaging to patients (just between users).

@bradymiller
Copy link
Sponsor Member

@shachar058 ,
Then how are you testing this? For example, I am pretty sure this would break patient messaging in the offsite portal.
-brady

@shachar058
Copy link
Contributor Author

shachar058 commented Oct 22, 2017

@bradymiller
We don't use it, but I have turned on offsite patient portal messaging for my testing. I didn't encounter any problems so far, but correct me if I missed something.
Why do you think it would break?

@bradymiller
Copy link
Sponsor Member

@shachar058 ,
Did it work on the offsite patient portal (ie. the ZH portal)? Just guessing it won't work since this was not the behavior previously. Just let me know how the testing goes. If it doesn't work, then will make sense to touch base with ZH since they'd likely want to add support for this feature.
-brady

@bradymiller bradymiller removed their assignment Oct 23, 2017
@shachar058
Copy link
Contributor Author

@bradymiller
I've never used ZH portal, so not even sure how to access it.
Could you maybe expand on this?

@bradymiller
Copy link
Sponsor Member

@shachar058 ,
Here's instructions for using the offsite portal:
https://www.open-emr.org/wiki/index.php/Patient_Portal#Instructions_3
(note that this is the only feature that uses this mechanism for patient messaging)

@sjpadgett , just to confirm, your patient portal does not use pnotes for patient messaging, correct?

@shachar058
Copy link
Contributor Author

@bradymiller
I followed the instructions for the patient offsite portal and all went well until I tried logging in to the mydocsportal, which responded with 'Invalid Access'.
Tried a few times with same problem, not sure why as I'm entering the creds exactly as told in the instructions.
Basically, having a lot of trouble with getting this ZH portal to work...

@sjpadgett
Copy link
Member

I use pnotes to mainly forward secure messages from a patient to another user from Dashboard. I also use it in Postings to send reminder to provider that an invoice has been sent to patient.

@shachar058
Copy link
Contributor Author

Hi @bradymiller,
I tried using the ZH portal again, but still am not able to access the portal.
If this testing is necessary then I'm a little stuck here, not sure how to proceed with this...

@bradymiller
Copy link
Sponsor Member

bradymiller commented Oct 30, 2017

hi @shachar058 ,
Let me see if I can get the portal going tonight on my local instance. If issues, then will bring in ZH to see if can help.
-brady

@sjpadgett
Copy link
Member

sjpadgett commented Oct 30, 2017 via email

@bradymiller
Copy link
Sponsor Member

I don't really know(since not sure how useful this is).
@shachar058 , what specific use case(s) is this feature(sending message to multiple patients) fulfilling?

@shachar058
Copy link
Contributor Author

Hi @bradymiller
In our clinic when the patients come in to get their medicine (once or twice a week for example), the doctor reads them the messages they have in their patient file. These can include reminders for bills they have to pay, reminders to go to certain appointments, changes that took place in their group appointments, and so on.
In order to be able to send these notices to all relevant patients at once (e.g. to notify all group members that the meeting location has changed), we need to be able to send messages to multiple patients at once.

@sjpadgett
Copy link
Member

Will look at more closely. The functionality is similar to my patient/dashboard chat where provider can send a message blast to one or more authorized portal patients. Not so with my secure messaging so, may be able to fit it in there. I have pnotes integrated so would be a matter of adding notification on portal landing page. My secure messaging does allow patient to reply to provider via dashboard where message is screened and forwarded to pnotes if necessary. Could be an interesting addition.

@bradymiller
Copy link
Sponsor Member

Also having a tough time getting the offsite patient portal to work (likely since I am using a new development environment and just need to get vpn support up and running); ill keep working on it.

The use case makes sense, especially since we have the Groups module option. Makes sense to get support for this in the new onsite demo ( @sjpadgett 's baby) and also in the offsite demo (I'll try to get ZH involved here).
-brady

@shachar058
Copy link
Contributor Author

Hi @bradymiller, any news on this?
Will it be possible to bring this in soon?
thanks,
shachar

@bradymiller
Copy link
Sponsor Member

hi @shachar058 ,
Sorry for the delay. Been busy with some security issues (these get my high priority), but plan to get back to this over the next 1-2 days.
-brady

@bradymiller
Copy link
Sponsor Member

Just tried out this and realized there is now a bug in the way the messaging is working.

There is no longer a way to explicitly send messages to patients (used to be a -Patient- selector), which meant the message was supposed to go to the patient. The other patient selector just means that the message is regarding the patient (does not mean it goes to the patient).

thoughts?

@bradymiller
Copy link
Sponsor Member

ok, figuring this out. turns out the patient to selector only shows when turn on the offsite portal:
matrix-israel@eee08a0#diff-413acece90704c1024806070613c874d

@sjpadgett , are you making use of the to patient messaging on this screen. If so, I'll also turn this on when the onsite portal is turned on.

@shachar058 ,
So can clarify the point of your code. Are your messaging meant to be going to the patients. or are they going to another user (but are regarding a group of patients)?

-brady

@sjpadgett
Copy link
Member

I don't use the flag. I only use the portal-user for forwarded messages from my dashboard to let provider know it's from patient. The patient info is in message content.
So nope, don't use.

@shachar058
Copy link
Contributor Author

@bradymiller we send it to users regarding patients not to the patients themselves (we don't use the offsite portal), but the user reads the messages in the patient file to the patient.

@bradymiller
Copy link
Sponsor Member

I think this is good. In the light of day, just plan to do one more analysis (following reply-to parameter to ensure no conflict between this and ZH's code).

@bradymiller bradymiller self-assigned this Nov 11, 2017
@bradymiller
Copy link
Sponsor Member

Light of day analysis looks good and will bring this into the codebase. Thanks for the contribution! -brady

@bradymiller bradymiller merged commit 39b7ef6 into openemr:master Nov 14, 2017
@shachar058 shachar058 deleted the messages_to_multiple_patients branch November 22, 2017 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants