Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enhance BaseService->getSelectFields to support table and column aliases #7370

Closed
adunsulag opened this issue Apr 17, 2024 · 0 comments · Fixed by #7371
Closed

feat: Enhance BaseService->getSelectFields to support table and column aliases #7370

adunsulag opened this issue Apr 17, 2024 · 0 comments · Fixed by #7371
Assignees
@adunsulag
Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Milestone
7.0.2.1

Comments

@adunsulag
Copy link
Sponsor Member

getSelectFields is a handy utility function to return all of the fields to be used in a select statement. However, if doing more complex joins or working with conflicting columns through multiple tables (or self-joins on the same table) we want to be able to have an alias of the table or of the columns of a table. We should modify the tables to support this.
@adunsulag adunsulag self-assigned this Apr 17, 2024
adunsulag added a commit to DiscoverAndChange/openemr that referenced this issue Apr 17, 2024
@adunsulag
Fixes openemr#7370 support select-fields alias
6e0debe 
This changes the getSelectFields method signature to support column and
table aliases.
@adunsulag adunsulag mentioned this issue Apr 17, 2024
Merged
adunsulag added a commit that referenced this issue Apr 18, 2024
@adunsulag
Fixes #7370 support select-fields alias (#7371)
7f38fd0 
This changes the getSelectFields method signature to support column and
table aliases.
sjpadgett pushed a commit to sjpadgett/openemr that referenced this issue Apr 22, 2024
@adunsulag @sjpadgett
Fixes openemr#7370 support select-fields alias (openemr#7371)
3669804 
This changes the getSelectFields method signature to support column and
table aliases.

(cherry picked from commit 7f38fd0)
@adunsulag adunsulag added this to the 7.0.2.1 milestone Apr 22, 2024
@adunsulag adunsulag added the developers This issue targets an issue that is for developers/collaborators/module writers/technical users label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adunsulag adunsulag

Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Projects
None yet
Milestone
7.0.2.1
Development

Successfully merging a pull request may close this issue.

Fixes #7370 support select-fields alias DiscoverAndChange/openemr
1 participant
@adunsulag