Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Extract billing code selector logic from options.inc.php into its own class #7323

Closed
adunsulag opened this issue Apr 5, 2024 · 0 comments · Fixed by #7324
Closed

feat: Extract billing code selector logic from options.inc.php into its own class #7323

adunsulag opened this issue Apr 5, 2024 · 0 comments · Fixed by #7324
Assignees
@adunsulag
Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Milestone
7.0.2.1

Comments

@adunsulag
Copy link
Sponsor Member

I need to be able to use the billing code selector logic in a module without having to grab everything needed to load the options.inc.php or LBF forms. As a user I want to just include the widget that is needed for the billing code selector and not have to deal with everything else.
@adunsulag adunsulag self-assigned this Apr 5, 2024
adunsulag added a commit to DiscoverAndChange/openemr that referenced this issue Apr 5, 2024
@adunsulag
Fixes openemr#7323 Billing Code Widget,deprecate isOption
7cbadd1 
This is a billing code selector widget that was used in options.inc.php.
I extracted it into its own class file so I can use it in a module as
well as use it in options.inc.php.

I also moved the options.inc.php isOption command to the LayoutUtils so
it can also be used externally.  I marked the isOption function as
deprecated.
@adunsulag adunsulag mentioned this issue Apr 5, 2024
Merged
@adunsulag adunsulag added this to the 7.0.2.1 milestone Apr 5, 2024
adunsulag added a commit that referenced this issue Apr 10, 2024
@adunsulag
Fixes #7323 Billing Code Widget,deprecate isOption (#7324)
ed9ffcc 
Fixes #7323 
This is a billing code selector widget that was used in options.inc.php.
I extracted it into its own class file so I can use it in a module as
well as use it in options.inc.php.

I also moved the options.inc.php isOption command to the LayoutUtils so
it can also be used externally.  I marked the isOption function as
deprecated.
sjpadgett pushed a commit to sjpadgett/openemr that referenced this issue Apr 16, 2024
@adunsulag @sjpadgett
Fixes openemr#7323 Billing Code Widget,deprecate isOption (openemr#7324)
3d3fafd 
Fixes openemr#7323
This is a billing code selector widget that was used in options.inc.php.
I extracted it into its own class file so I can use it in a module as
well as use it in options.inc.php.

I also moved the options.inc.php isOption command to the LayoutUtils so
it can also be used externally.  I marked the isOption function as
deprecated.

(cherry picked from commit ed9ffcc)
@adunsulag adunsulag added the developers This issue targets an issue that is for developers/collaborators/module writers/technical users label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adunsulag adunsulag

Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Projects
None yet
Milestone
7.0.2.1
Development

Successfully merging a pull request may close this issue.

Fixes #7323 Billing Code Widget,deprecate isOption DiscoverAndChange/openemr
1 participant
@adunsulag