Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: PatientValidator email address should not fail to validate with empty string "" for email #7219

Closed
adunsulag opened this issue Feb 11, 2024 · 0 comments · Fixed by #7220
Closed

bug: PatientValidator email address should not fail to validate with empty string "" for email #7219

adunsulag opened this issue Feb 11, 2024 · 0 comments · Fixed by #7220
Assignees
@adunsulag
Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Milestone
7.0.2.1

Comments

@adunsulag
Copy link
Sponsor Member

If a patient record has an empty email address which is the default value for an inserted patient_data record, it will fail to update if the email address remains empty. We need to change up the logic so that an empty string is allowed. We should only do the email validation if the email actually has values. This bug has existed since March 3, 2023.
@adunsulag adunsulag self-assigned this Feb 11, 2024
adunsulag added a commit to DiscoverAndChange/openemr that referenced this issue Feb 11, 2024
@adunsulag
Fixes openemr#7219 email validate allow empty strings.
42b4ed1 
This allows empty strings to be validated.  Fixes openemr#7219.
@adunsulag adunsulag mentioned this issue Feb 11, 2024
Merged
adunsulag added a commit that referenced this issue Feb 12, 2024
@adunsulag
Fixes #7219 email validate allow empty strings. (#7220)
8ac331b 
This allows empty strings to be validated.  Fixes #7219.
sjpadgett pushed a commit to sjpadgett/openemr that referenced this issue Feb 22, 2024
@adunsulag @sjpadgett
Fixes openemr#7219 email validate allow empty strings. (openemr#7220)
5c94734 
This allows empty strings to be validated.  Fixes openemr#7219.

(cherry picked from commit 8ac331b)
@adunsulag adunsulag added this to the 7.0.2.1 milestone Apr 23, 2024
@adunsulag adunsulag added the developers This issue targets an issue that is for developers/collaborators/module writers/technical users label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adunsulag adunsulag

Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Projects
None yet
Milestone
7.0.2.1
Development

Successfully merging a pull request may close this issue.

Fixes #7219 email validate allow empty strings. DiscoverAndChange/openemr
1 participant
@adunsulag