Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: InstallerController needs to pass current status to ModuleManagerAfterActionListener action methods #7214

Closed
adunsulag opened this issue Feb 11, 2024 · 0 comments · Fixed by #7215
Closed

bug: InstallerController needs to pass current status to ModuleManagerAfterActionListener action methods #7214

adunsulag opened this issue Feb 11, 2024 · 0 comments · Fixed by #7215
Assignees
@adunsulag
Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Milestone
7.0.2.1

Comments

@adunsulag
Copy link
Sponsor Member

If the module action fails the ModuleManagerAfterActionListener needs to be aware that the system is already in a failure state. We need to pass the current action status into InstallerController. It looks like this was the original intent but was likely overlooked.

This is in InstallerController.php#L216
@adunsulag adunsulag self-assigned this Feb 11, 2024
adunsulag added a commit to DiscoverAndChange/openemr that referenced this issue Feb 11, 2024
@adunsulag
Fixes openemr#7214 pass action status to listener
1d7ccf8 
Action status was not being passed in the listener.
Fixes openemr#7214
@adunsulag adunsulag mentioned this issue Feb 11, 2024
Merged
adunsulag added a commit that referenced this issue Feb 11, 2024
@adunsulag
Fixes #7214 pass action status to listener (#7215)
b0cfafc 
Action status was not being passed in the listener.
Fixes #7214
sjpadgett pushed a commit to sjpadgett/openemr that referenced this issue Feb 22, 2024
@adunsulag @sjpadgett
Fixes openemr#7214 pass action status to listener (openemr#7215)
5a9f23b 
Action status was not being passed in the listener.
Fixes openemr#7214

(cherry picked from commit b0cfafc)
@adunsulag adunsulag added this to the 7.0.2.1 milestone Apr 23, 2024
@adunsulag adunsulag added the developers This issue targets an issue that is for developers/collaborators/module writers/technical users label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adunsulag adunsulag

Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Projects
None yet
Milestone
7.0.2.1
Development

Successfully merging a pull request may close this issue.

Fixes #7214 pass action status to listener DiscoverAndChange/openemr
1 participant
@adunsulag