Added ZFS-exporter as sidecar container and service monitor in the helm chart #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deveshs23
force-pushed
the
zfs-exporter
branch
2 times, most recently
from
d152b76
to
106c9c5
Compare
Signed-off-by: Devesh Sharma <[email protected]>
| # Make sure that registry name end with a '/'. | ||
| # For example : registry.k8s.io/ is a correct value here and quay.io is incorrect | ||
| registry: harbor.obmondo.com/ | ||
| repository: obmondo/zfs_exporter |
There was a problem hiding this comment.
Hi @Deveshs23 Many thanks for your contribution. We would like to understand that where is the code for the image that is being referred here lives? How does it operate with openebs zfs-localpv?
We would appreciate if the code lives in this repo, that the community will be able to maintain and extend it.
Also the monitoring stack for zfs is already present. Please check openebs/monitoring repo.
We currently export these metrics for zfs.
You are welcome to add to the above list of metrics. In that case please follow this:
- Add the metrics/exporter code to zfs-localpv repo.
- Add the monitoring code to monitoring repo.
- Add the helm chart changes if needed to monitoring helm charts.
|
@Deveshs23 Are you still interested in this? We haven't received any information on the last thread. Closing this for now, please feel free to open if you think otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
Added a ZFS exporter for monitoring zpool
Does this PR require any upgrade changes?:
no
sign-off: [email protected]
PR sponsored by Obmondo.com