specs-go: sync SCMP_ARCH_* constants with libseccomp main #1229
Conversation
The following constants are defined in the main branch of libseccomp, but not included in its latest release (v2.5) yet: * SCMP_ARCH_LOONGARCH64 (seccomp/libseccomp@6966ec7) * SCMP_ARCH_M68K (seccomp/libseccomp@dd5c9c2) * SCMP_ARCH_SH (seccomp/libseccomp@c12945d) * SCMP_ARCH_SHEB (seccomp/libseccomp@c12945d) These constant names are unlikely to change before v2.6 GA, so we can safely refer to them in specs-go. Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
requested review from
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon,
vbatts and
utam0k
as code owners
|
Ideally we should just wait for libseccomp v2.6 GA, but new releases don't seem to be going to happen very soon |
Would there be any consequences if this arch is used in a profile, but the libseccomp version that's used doesn't have it yet? (sorry, I'm lazy, thought I'd ask as maybe you know from the top of your head); bad memories of those cases where certain distros only had outdated versions 😓 |
The runtime impl will raise an error. (Same as other archs) |
| <!-- | ||
| The following constants are defined in the main branch of libseccomp, | ||
| but not included in its latest release (v2.5) yet: | ||
| https://github.com/seccomp/libseccomp/commits/main/include/seccomp.h.in | ||
|
|
||
| * SCMP_ARCH_LOONGARCH64 | ||
| * SCMP_ARCH_M68K | ||
| * SCMP_ARCH_SH | ||
| * SCMP_ARCH_SHEB | ||
| --> |
There was a problem hiding this comment.
I created an issue and assigned it to me so that we would not forget to update it.
#1231
|
@kolyshkin PTAL |
|
ping @kolyshkin 🙏 |
The following constants are defined in the main branch of libseccomp, but not included in its latest release (v2.5) yet:
SCMP_ARCH_LOONGARCH64(seccomp/libseccomp@6966ec7)SCMP_ARCH_M68K(seccomp/libseccomp@dd5c9c2)SCMP_ARCH_SH(seccomp/libseccomp@c12945d)SCMP_ARCH_SHEB(seccomp/libseccomp@c12945d)These constant names are unlikely to change before v2.6 GA, so we can safely refer to them in specs-go.
Replaces: