OBPIH-6490 Validations on pick page buttons #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alannadolny
approved these changes
Jun 24, 2024
Comment on lines
+743
to
+745
| onClick: () => { | ||
| this.clearPicklist(); | ||
| }, |
There was a problem hiding this comment.
could this be shortened to:
Suggested change
| onClick: () => { | |
| this.clearPicklist(); | |
| }, | |
| onClick: this.clearPicklist |
?
| @@ -906,7 +951,7 @@ class PickPage extends Component { | |||
| </a> | |||
| <button | |||
| type="button" | |||
| onClick={() => this.clearPicklist()} | |||
| onClick={() => this.confirmClearPicklist()} | |||
There was a problem hiding this comment.
Suggested change
| onClick={() => this.confirmClearPicklist()} | |
| onClick={this.confirmClearPicklist} |
There was a problem hiding this comment.
@alannadolny this might be a shortcut, but I believe I explained once, that I don't like passing arguments that are not used in a method.
Your suggestion would make this evaluate to:
onClick={(e) => this.confirmClearPicklist(e)}even though we do not expect to pass any param to this method.
Why I remember this is that once, I gave you the opposite suggestion in a PR 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.