OBPIH-6520 Set up for date localization in DD/Month/YYYY format for Es and Mx locales

[alannadolny]

Usage:

1. G tag

<g:formatDate date="${new Date()}" formatName="${org.pih.warehouse.DateFormatName.CUSTOM.id}"/>
<g:formatDate date="${new Date()}" formatName="${org.pih.warehouse.DateFormatName.DEFAULT.id}"/>
<g:formatDate date="${new Date()}" formatName="${org.pih.warehouse.DateFormatName.EXPIRY.id}"/>

2. Grails util

LocalizationUtil.formatDate(new Date(), DateFormatName.EXPIRY)
LocalizationUtil.formatDate(new Date(), DateFormatName.CUSTOM)
LocalizationUtil.formatDate(new Date(), DateFormatName.DEFAULT)

3. React component

<FormatDate date={new Date()} formatName={DateFormatName.DEFAULT} />
<FormatDate date={new Date()} formatName={DateFormatName.EXPIRY} />
<FormatDate date={new Date()} formatName={DateFormatName.CUSTOM} />

[EWaterman]

we're only changing the format to dd/MMM/yyyy for ex_MX? Do we not want all locals to have the new format?

[awalkowiak]

I think that others should have a default right now.

[EWaterman]

I'm not sure if this is the types we want. DEFAULT and CUSTOM are more generic sounding while EXPIRY is for a very specific purpose (product expiration). It's mixing and matching a bit.

What are you imagining is the behaviour if we add a new feature X that also needs to display only month and year? Would it re-use the EXPIRY type or would it need to create its own X type that also formats MMM/yyyy?

My instinct tells me that we'd be better off with more directly descriptive types (ex: DATE_TIME, FULL_DATE. MONTH_YEAR) but let me know your thoughts

[EWaterman]

and if you want to avoid having DEFAULT be in the enum itself you could move it to a constant in the enum:

public final DateFormatName DEFAULT = DATE_TIME

[EWaterman]

I think something like "property" is more accurate of a field name

[EWaterman]

thanks for making these changes but now the actual properties themselves don't match.

I was thinking we'd have something like:

datetime.format=DD/MMM/yyyy hh:mm:ss a z
date.format=DD/MMM/yyyy
monthyear.format=MMM/yyyy

the monthyear one is hard to decide on what a good wording would be but maybe it's clear enough like that.