OBPIH-6486: hibernate errors running tests against different contexts #4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWaterman
commented
Jun 11, 2024
There was a problem hiding this comment.
This is the only real change. The comment in the todo and in the ticket should hopefully explain the situation.
Eventually I want to break this class up into ApiSpecConfig, SliceSpecConfig, SmokeSpecConfig... which can each do their own component scan for whatever test components they need, but I spent hours trying to get that to work and just couldn't find out what was causing the hibernate errors.
|
Got the 🟢 from Justin offline. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pihemr.atlassian.net/browse/OBPIH-6486
This change doesn't actually fix the issue, but it does make tests pass while we figure out the cause. There's something strange going on with how hibernate is loading our domains in the app context during tests that is preventing us from having some tests use some context config and other tests use another config.
I also took the opportunity to restructure our packages. Now it works like:
with API, slice, and smoke tests being separated into their own packages which we can run independently if we want.