OBGM-328 unit test cases for Grails 3 #4614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fixed and passed. Overall 25% test cases are passed. As per new grails 3 i made the code changes so atleast test cases are running now with command "grails test-app -Unit"
|
@chetanmaharishi As we discussed on Slack can you please create a PR for just the TransactionTypeSpec (including any other changes that it depends on). You can keep this branch lying around as we'll probably come back to it once we have a chance to review the reference implementation. I am expecting that we'll be able to go through each @ignore'd test and convert them one by one, following the conventions laid out by the TransactionTypeSpec. cc @EWaterman |
awalkowiak
changed the base branch from
feature/upgrade-to-grails-3.3.10
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow this PR also for previous commit
#4608
Now i have create one DomainUnit test case for TransactionType domain.