OBPIH-6114 Add tiered pricing to product supplier #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchelstowski
reviewed
Mar 5, 2024
|
|
||
| addColumn(tableName: "product_supplier") { | ||
| column(name: "tiered_pricing", type: "bit") { | ||
| constraints(nullable: "false") |
There was a problem hiding this comment.
should it be nullable: false if it's considered as an optional field?
There was a problem hiding this comment.
I mean - what with already existing product sources? If we don't want to allow null, shouldn't we add a default bool value in migration?
There was a problem hiding this comment.
Existing ones got false by default.
kchelstowski
approved these changes
Mar 5, 2024
alannadolny
approved these changes
Mar 5, 2024
awalkowiak
added a commit
that referenced
this pull request
Mar 12, 2024
* OBPIH-6114 Add tiered pricing to product supplier * OBPIH-6114 Set default tiered pricing to false on command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.