OBPIH-6052 validation for zero items to invoice in invoices workflow (post QA) #4509
Conversation
- added zero items validation dialog on save - refetch items after save - added zero items validation on save & exit - removed items save on Open invoice item cadidates
| <InvoiceItemsModal | ||
| btnOpenText="react.default.button.addLines.label" | ||
| btnOpenDefaultText="Add lines" | ||
| onOpen={() => saveInvoiceItems(values)} |
There was a problem hiding this comment.
This onOpen callback would fire a saveItems post request after we opened the dialog for invoice item candidates.
I was looking through PR's and tickets to find the reason behind this logic implementation and was not able to find anything.
It was implemented as part of OBPIH-3614.
To me this looks like a side effect that users might not expect especially with the new logic where we remove rows with 0 quantity.
If I have to leave this callback it would result in following behavior:
- user ads items
- user updates some items quantity to 0
- user opens dialog
- save items request is sent
- rows with 0 items disappear
result: user is confused about what just happened because he did;t click save or anything of sorts.
This looks like a weird side effect that should not happen when opening a dialog and I was not able to figure out any use cases for its existence.
So correct me if I am worng
There was a problem hiding this comment.
The case behind this was that when the user had partial invoice quantity, and then revised the quantity to a non-zero value, and then entered back the add items modal. This save prevented wrong invoice item candidate's quantities while coming back to add items and having some revisions in progress. IMHO this still needs to work this way. If you want to avoid confusion, you can show a message, that zeroed items will be removed.
There was a problem hiding this comment.
ok I can bring it back but in my opinion this will be not a pleasant experience for a user.
This looks like a side effect that user might not want to happen.
I will mention this case in the ticket and will want to hear an opinion after UAT.
I would suggest revisitng this case and coming up with some other mechanism or cases, but as part of a different ticket.
| <InvoiceItemsModal | ||
| btnOpenText="react.default.button.addLines.label" | ||
| btnOpenDefaultText="Add lines" | ||
| onOpen={() => saveInvoiceItems(values)} |
There was a problem hiding this comment.
The case behind this was that when the user had partial invoice quantity, and then revised the quantity to a non-zero value, and then entered back the add items modal. This save prevented wrong invoice item candidate's quantities while coming back to add items and having some revisions in progress. IMHO this still needs to work this way. If you want to avoid confusion, you can show a message, that zeroed items will be removed.
- display validation dialog before opening invoice item candidates - added renderButton prop in ModalWrapper for custom button renders
|
@awalkowiak I brought back this behavior of saving current items before displaying candidates. |
awalkowiak
deleted the
OBPIH-6052-validation-for-zero-items-to-invoice-in-invoices-workflow
branch
There were missing places where the same validation modal had to appear on invoice creation workflow like: