OBGM-757 Update project's README.md for the Grails 3 version #4425
Conversation
kchelstowski
requested review from
jmiranda,
awalkowiak,
drodzewicz and
alannadolny
README.md
Outdated
| * [Java 7 (must install Java 7)](https://www.azul.com/downloads/?version=java-7-lts&package=jdk) | ||
| * [MySQL 5.7](https://downloads.mysql.com/archives/community/) | ||
| * [Java 8 (must install Java 8)](https://www.oracle.com/pl/java/technologies/javase/javase8-archive-downloads.html) or via SDK | ||
| * [MySQL 5.7](https://downloads.mysql.com/archives/community/) or [MariaDB 10.11.4](https://mariadb.com/kb/en/mariadb-10-11-4-release-notes/) |
There was a problem hiding this comment.
I am not sure if it should be MySql 5.7. Shouldn't it be MySQL version 8?
There was a problem hiding this comment.
@alannadolny I don't know, locally I've always had 5.7 and it's been working even with Grails 3, so I am not sure what the suggested version should be here.
Maybe @jmiranda @awalkowiak have any suggestions?
There was a problem hiding this comment.
I think it could be all three versions 5.7, 8, and Maria, but perhaps we should start getting rid of 5.7? @jmiranda thoughts?
There was a problem hiding this comment.
See Matt's recommendations https://pihemr.atlassian.net/browse/OBS-1469
Artur is right, we support MySQL 5.7 and MySQL 8.0, as well as MariaDB 10.2 through 10.11.3.
We do not officially support MySQL 8.1 or MariaDB 11.
Also, there are a few issues related to the MySQL 8 upgrade that could be highlighted in the docs.
https://github.com/openboxes/openboxes/issues?q=is%3Aissue+mysql+8+is%3Aopen+
Lastly, there's at least one other PR with some changes related to the database documentation that should be reviewed.
#3768
awalkowiak
changed the base branch from
feature/upgrade-to-grails-3.3.10
to
release/0.9.0
There was a problem hiding this comment.
Looks like these changes are not visible here: e19d7df. Could you fix badges (remove the broken travis badge and slack signup badge), you don't have to add the unit and integration tests badges (I will add a task to restore it to the ticket in which these actions will be fixed) and update "Deployment Options" if needed.
README.md
Outdated
| * Mac users: 5.7.31 is the latest 5.7.x with a pre-built installer and works fine | ||
| * [SDK Man](https://sdkman.io/install) | ||
| * [Grails 1.3.9](https://grails.org/download.html) | ||
| * [Grails 3.3.10](https://grails.org/download.html) |
There was a problem hiding this comment.
Technically it should be 3.3.17 now. Although in the gradle.properties we have 3.3.16, however, this version is not present on the list of older grails versions on the download page. So I think we should have 3.3.17 here.
|
I'm still waiting for @jmiranda 's final opinion about the DB stuff, so I'm not including that change yet. |
No description provided.