OBPIH-6004 Add ability to create a final invoice for partially shipped orders #4422
Conversation
drodzewicz
added
the
warn: do not merge
| @@ -259,6 +260,10 @@ class Order implements Serializable { | |||
| return activeOrderItems?.every { OrderItem orderItem -> orderItem.isCompletelyFulfilled() } | |||
| } | |||
|
|
|||
| Boolean isPartiallyShipped() { | |||
| return activeOrderItems?.any { OrderItem orderItem -> orderItem.isCompletelyFulfilled() } | |||
There was a problem hiding this comment.
I think it can be shortened to:
| return activeOrderItems?.any { OrderItem orderItem -> orderItem.isCompletelyFulfilled() } | |
| return activeOrderItems?.any { it.isCompletelyFulfilled() } |
There was a problem hiding this comment.
@drodzewicz what if every item is completely fulfilled? Then this will be both shipped and partiallyShipped. I think you should either check if it is && !shipped or check if activeOrderItems?.any { it.isPartiallyFulfilled() } (I think I prefer the later version)
There was a problem hiding this comment.
good point, I'll fix that
There was a problem hiding this comment.
I prefer using a static type with closures but we can discuss if this is preferred.
| @@ -259,6 +260,10 @@ class Order implements Serializable { | |||
| return activeOrderItems?.every { OrderItem orderItem -> orderItem.isCompletelyFulfilled() } | |||
| } | |||
|
|
|||
| Boolean isPartiallyShipped() { | |||
| return activeOrderItems?.any { OrderItem orderItem -> orderItem.isCompletelyFulfilled() } | |||
There was a problem hiding this comment.
@drodzewicz what if every item is completely fulfilled? Then this will be both shipped and partiallyShipped. I think you should either check if it is && !shipped or check if activeOrderItems?.any { it.isPartiallyFulfilled() } (I think I prefer the later version)
| @@ -259,6 +260,10 @@ class Order implements Serializable { | |||
| return activeOrderItems?.every { OrderItem orderItem -> orderItem.isCompletelyFulfilled() } | |||
| } | |||
|
|
|||
| Boolean isPartiallyShipped() { | |||
| return activeOrderItems?.any { OrderItem orderItem -> orderItem.isCompletelyFulfilled() } | |||
There was a problem hiding this comment.
I prefer using a static type with closures but we can discuss if this is preferred.
both cases when shipped item quantity is partially and completely fulfiled
drodzewicz
force-pushed
the
OBPIH-6004-generate-invoice-for-prepayment-po-before-all-items-are-shipped
branch
from
22ce6da
to
bf8372e
Compare
drodzewicz
changed the base branch from
feature/upgrade-to-grails-3.3.10
to
release/0.9.0-hotfix1
drodzewicz
added
needs attention
status: needs discussion
drodzewicz
added
the
warn: do not merge
|
I am closing this one, because either the scope will change, or this won't be finalized at all in the state it was requested by a user. |
No description provided.