OBPIH-5980 Data display error in Delivery Note when Pack level 1 is entered #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… header is not visible
alannadolny
requested review from
jmiranda,
awalkowiak,
drodzewicz and
kchelstowski
alannadolny
added
the
warn: do not merge
|
I added a |
| @@ -65,7 +65,7 @@ | |||
| </g:each> | |||
| </td> | |||
| </g:if> | |||
| <g:if test="${requisitionItems.find { it.requisition?.shipment?.shipmentItems?.any { it.container }}}"> | |||
| <g:if test="${requisitionItems.find { it.requisition?.shipment?.shipmentItems?.any { it.container && it.container?.parentContainer }}}"> | |||
There was a problem hiding this comment.
wouldn't just:
.any { it.container?.parentContainer }work?
drodzewicz
approved these changes
Dec 18, 2023
alannadolny
changed the base branch from
feature/upgrade-to-grails-3.3.10
to
release/0.9.0-hotfix1
alannadolny
removed
the
warn: do not merge
jmiranda
requested changes
Dec 21, 2023
| @@ -65,7 +65,7 @@ | |||
| </g:each> | |||
| </td> | |||
| </g:if> | |||
| <g:if test="${requisitionItems.find { it.requisition?.shipment?.shipmentItems?.any { it.container }}}"> | |||
| <g:if test="${requisitionItems.find { it.requisition?.shipment?.shipmentItems?.any { it.container?.parentContainer }}}"> | |||
There was a problem hiding this comment.
From what I can tell from the revision history, the code has gone from something like this
<g:if test="${shipmentItems.any { it.container }}">
to this
<g:if test="${shipmentItems.any { it.container && it.container?.parentContainer }}">
and now to this
<g:if test="${requisitionItems.find { it.requisition?.shipment?.shipmentItems?.any { it.container }}}">
I have no idea what this code is trying to achieve, so I feel like now would be a good time to move this logic to the domain. I just don't know exactly which object to interogate to get this information. Shipment? Requisition?
In either case, it should probably live outside of whatever loop we're iterating over in case the method is expensive (i.e. requires database integration).
whateverObjectWeShouldInterogate.hasParentContainer()
whateverObjectWeShouldInterogate.hasChildContrainer()
awalkowiak
approved these changes
Dec 22, 2023
awalkowiak
pushed a commit
that referenced
this pull request
Jan 25, 2024
…ntered (#4421) * OBPIH-5980 Add additional condition to avoid adding cell when related header is not visible * OBPIH-5980 Fix after review * OBPIH-5980 Move some logic from printPage to shipment domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.