OBGM-130 Refactor database migration trigger in BootStrap.groovy to avoid having to update list of existing versions #4391
Conversation
There was a problem hiding this comment.
Looks good to me. Great find on that API, @alannadolny. Minor changes requested.
| // Find directories with names matching current versions pattern | ||
| List<String> changelogVersions = resources | ||
| .collect { it.filename } | ||
| .findAll { it.matches("[0-9]{1,3}.[0-9]{1,3}.x") } |
There was a problem hiding this comment.
Can you also add a comment to describe the regexp being used? Something like
// Find directories with names matching current versions pattern which
// will match to any version number between 0.0.x to 999.999.x
Also let's replace [0-9] with
.findAll { it.matches("[[:digit:]]{1,3}.[[:digit:]]{1,3}.x") }
There was a problem hiding this comment.
It's interesting, because [[:digit:]] seems to be not working 🤔
neither with single [:
but it works with \d and just [0-9]:
| .reverse() | ||
|
|
||
| // Exclude the newest changelog version, this one should be run separately | ||
| List<String> previousChangelogVersions = changelogVersions.size() ? changelogVersions.tail() : [] |
There was a problem hiding this comment.
Rename all the directories under migrations so nothing matches and see what happens. I want to check whether we need to add null safety.
If you need to change the code, also replace
changelogVersions.size()
with
!changelogVersions.empty
just to make it more readable
There was a problem hiding this comment.
.size was working, but I changed this method to .empty to increase readability
|
Also, fix the conflict. |
There was a problem hiding this comment.
While working on other tickets related to db changelogs I noticed, that if you run the install changelogs on fresh db, and then current 0.9.0 changelogs, then on each app start bootstrap thinks that previous changelogs were not yet executed and will try to again install db from scratch. I think we need to expand the logic here to cover or look into either if there were any install changelogs executed or any current version changelogs executed, and based on that execute proper changelogs.
(part of the issues I had were caused after changing a branch and having different changeset IDs in the install/changelogs..., so normally it should be no problem to rerun install changelogs because those executed would be skipped, so treat this rather as a "comment", not necessarily as a "change request", but I'd like to discuss it. Additionally, this ticket: https://pihemr.atlassian.net/browse/OBGM-133 might be more suitable for this)
The description / Question is moved to the ticket