OBGM-714 Approve request label broken + no flash message when adding APPROVE_REQUEST activity #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#4277) * OBPIH-5768 Add request approval supported activity to the Location domain * OBPIH-5798 Remove validation for request approval supported activity, and instead return an information message * OBPIH-5798 Render list of messages using flash.messages * OBPIH-5798 Create RenderMessageTagLib which handles rendering of messages passed by flash.message * OBPIH-5798 Move renderMessage to MessageTagLib * OBPIH-5798 Use APPROVE_REQUEST Activity code instead of REQUEST_APPROVAL --------- Co-authored-by: Darek Rodzewicz <[email protected]> (cherry picked from commit 19bf7ec)
kchelstowski
requested review from
jmiranda,
awalkowiak,
drodzewicz and
alannadolny
jmiranda
requested changes
Nov 1, 2023
There was a problem hiding this comment.
I didn't really like this solution when it was implemented so I think we should try to fix it in this PR. The solution is to use the raw codec https://blog.mrhaki.com/2013/11/grails-goodness-generating-raw-output.html
<g:if test="${flash.message}">
<div class="message">${raw(flash.message)}</div>
</g:if>
|
Here's a screenshot from the latest version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…… (#4277)
This one seems to have been skipped while cherry-picking request approval PRs into Grails 3.
It's #4277 that I've cherry-picked now and has been skipped here: #4357