OBPIH-5805 Approver cannot edit requests - Approvals end to end workflow (fix after QA) #4320
Conversation
src/js/utils/permissionUtils.js
Outdated
| if (isApprovalRequired) { | ||
| // If the request is approved, approver cannot edit request, | ||
| // but normal warehouse user can edit it |
There was a problem hiding this comment.
what do we mean by "normal warehouse user can edit it"?
Below I can see that you check if isUserRequestor, so that would mean that if request is approved, only requestor can edit that, is that true?
There was a problem hiding this comment.
I forgot that I did all of the requests from one account - so I was the only requestor here 🫣
| if (request.statusCode === RequisitionStatus.APPROVED && isUserApprover) { | ||
| return false; | ||
| } | ||
| // If the location supports request approval, only the requestor is able to edit |
There was a problem hiding this comment.
here you answered my question from above, but I'm confused about this "normal warehouse user can edit it".
…but, we are not requestor
src/js/utils/permissionUtils.js
Outdated
| return isUserRequestor && | ||
| (isLocationDestination || isLocationOrigin) && | ||
| request.statusCode !== RequisitionStatus.REJECTED; | ||
| return request.statusCode === RequisitionStatus.APPROVED && !isUserApprover; |
There was a problem hiding this comment.
doesn't this "normal user" have to be in either destination or origin in order to be able to edit it?
src/js/utils/permissionUtils.js
Outdated
| request.statusCode !== RequisitionStatus.REJECTED; | ||
| } | ||
| // If the request is approved, approver cannot edit request, | ||
| // but fulfilling user can edit it |
There was a problem hiding this comment.
This makes no sense to me (I understand that it was requested to work that way), but this still makes no sense to me. I see the use case where I have one person doing approvals and fulfilling.
…low (fix after QA) (#4320) * OBPIH-5805 enable editing request when it is approved * OBPIH-5805 Change conditions to fix editing when request is approved but, we are not requestor * OBPIH-5805 Add origin to condition * OBPIH-5805 Change comment in permission util * OBPIH-5805 Allow edit for users who are approvers
No description provided.